Taboola Bid Adapter: fix multiple impressions bug #9104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taboolaBidAdapter_spec.js - new UT
taboolaBidAdapter_spec.js - new UT
* refactor code for better readability * small fix in UT
* add relevant Ut * small fixes in UT
…-taboola-bid-adapter Merge from prebid
…d-taboola-bid-adapter
* add relevant Ut * small fixes in md
* add relevant Ut * small fixes
* add relevant Ut * small fixes
* update UT * Update banner End point structure
Add taboola bid adapter
…otocols + update Ut
update md (placement + pub )
support-dynamic-endpoint-url
…ster � Conflicts: � modules/taboolaBidAdapter.js � modules/taboolaBidAdapter.md
Taboola Adapter - Adding Optional Chaining
set netRevenue to true.
fix bid response in case we have multiple impressions
|
@shakhaltb can you please fix the linting error from this pr? |
|
@ChrisHuie fixed lint, thank you |
ChrisHuie
approved these changes
Oct 12, 2022
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* create taboola adapter * create taboola adapter md * taboolaBidAdapter.js - small fixes taboolaBidAdapter_spec.js - new UT * taboolaBidAdapter.js - small fixes taboolaBidAdapter_spec.js - new UT * update the md * update the Maintainer email * * update MD page * refactor code for better readability * small fix in UT * * add privacy to the request builder * add relevant Ut * small fixes in UT * * code refactoring + add more accurate way to get page url and referer * add relevant Ut * small fixes in md * * code refactoring + gte user id * add relevant Ut * small fixes * * code refactoring + gte user id * add relevant Ut * small fixes * * update end point url * update UT * Update banner End point structure * small fixes + update epi url * remove the destruction from the bidResponse property * (update the unit tests) remove the destruction from the bidResponse property * fix tests * fix tests - run stubs on each test * rerun because of another adapter flaky test * rerun because of another adapter flaky test * fix cors issue, switch between height, width position * update badv, bcat to be based in the ortb2 to support prebid 7 new protocols + update Ut * retry run circleci * retry run circleci * pull from upstream update md (placement + pub ) * update badv, bcat UT * rerun build * rerun build * support storageAllowed restriction on unit tests for prebid 7 * create taboola adapter * create taboola adapter md * taboolaBidAdapter.js - small fixes taboolaBidAdapter_spec.js - new UT * taboolaBidAdapter.js - small fixes taboolaBidAdapter_spec.js - new UT * update the md * update the Maintainer email * * update MD page * refactor code for better readability * small fix in UT * * add privacy to the request builder * add relevant Ut * small fixes in UT * * code refactoring + add more accurate way to get page url and referer * add relevant Ut * small fixes in md * * code refactoring + gte user id * add relevant Ut * small fixes * * code refactoring + gte user id * add relevant Ut * small fixes * * update end point url * update UT * Update banner End point structure * small fixes + update epi url * remove the destruction from the bidResponse property * (update the unit tests) remove the destruction from the bidResponse property * fix tests * fix tests - run stubs on each test * rerun because of another adapter flaky test * rerun because of another adapter flaky test * fix cors issue, switch between height, width position * update badv, bcat to be based in the ortb2 to support prebid 7 new protocols + update Ut * retry run circleci * retry run circleci * pull from upstream update md (placement + pub ) * update badv, bcat UT * rerun build * rerun build * support storageAllowed restriction on unit tests for prebid 7 * support storageAllowed restriction on unit tests for prebid 7 * add it also to the aftereach * add it also to the aftereach * change the api endpoint https protocol * update Taboola prebid documentation: tagId, publisherId, bidFloor. * update bid response ttl to 60 seconds. * update Taboola prebid documentation. * update-ttl-passing * Update taboolaBidAdapter_spec.js * add fallback default value in case of null * add semicolons * . * . * . * .. * ... * support-dynamic-endpoint-url * support-dynamic-endpoint-url * support-dynamic-endpoint-url * support-dynamic-endpoint-url * support-dynamic-endpoint-url * support-dynamic-endpoint-url * support-dynamic-endpoint-url * optional-chaining * set netRevenue to true. * fix bid response in case we have multiple impressions * add test * fix lint Co-authored-by: Michael <michael.ziso@taboola.com> Co-authored-by: mikiz <31058500+mikizi@users.noreply.github.com> Co-authored-by: jenny.l <jenny.l@taboola.com> Co-authored-by: jennylt <48404417+jennylt@users.noreply.github.com> Co-authored-by: Ahmad Lobany <ahmad.l@taboola.com> Co-authored-by: ahmadlob <109217988+ahmadlob@users.noreply.github.com>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* create taboola adapter * create taboola adapter md * taboolaBidAdapter.js - small fixes taboolaBidAdapter_spec.js - new UT * taboolaBidAdapter.js - small fixes taboolaBidAdapter_spec.js - new UT * update the md * update the Maintainer email * * update MD page * refactor code for better readability * small fix in UT * * add privacy to the request builder * add relevant Ut * small fixes in UT * * code refactoring + add more accurate way to get page url and referer * add relevant Ut * small fixes in md * * code refactoring + gte user id * add relevant Ut * small fixes * * code refactoring + gte user id * add relevant Ut * small fixes * * update end point url * update UT * Update banner End point structure * small fixes + update epi url * remove the destruction from the bidResponse property * (update the unit tests) remove the destruction from the bidResponse property * fix tests * fix tests - run stubs on each test * rerun because of another adapter flaky test * rerun because of another adapter flaky test * fix cors issue, switch between height, width position * update badv, bcat to be based in the ortb2 to support prebid 7 new protocols + update Ut * retry run circleci * retry run circleci * pull from upstream update md (placement + pub ) * update badv, bcat UT * rerun build * rerun build * support storageAllowed restriction on unit tests for prebid 7 * create taboola adapter * create taboola adapter md * taboolaBidAdapter.js - small fixes taboolaBidAdapter_spec.js - new UT * taboolaBidAdapter.js - small fixes taboolaBidAdapter_spec.js - new UT * update the md * update the Maintainer email * * update MD page * refactor code for better readability * small fix in UT * * add privacy to the request builder * add relevant Ut * small fixes in UT * * code refactoring + add more accurate way to get page url and referer * add relevant Ut * small fixes in md * * code refactoring + gte user id * add relevant Ut * small fixes * * code refactoring + gte user id * add relevant Ut * small fixes * * update end point url * update UT * Update banner End point structure * small fixes + update epi url * remove the destruction from the bidResponse property * (update the unit tests) remove the destruction from the bidResponse property * fix tests * fix tests - run stubs on each test * rerun because of another adapter flaky test * rerun because of another adapter flaky test * fix cors issue, switch between height, width position * update badv, bcat to be based in the ortb2 to support prebid 7 new protocols + update Ut * retry run circleci * retry run circleci * pull from upstream update md (placement + pub ) * update badv, bcat UT * rerun build * rerun build * support storageAllowed restriction on unit tests for prebid 7 * support storageAllowed restriction on unit tests for prebid 7 * add it also to the aftereach * add it also to the aftereach * change the api endpoint https protocol * update Taboola prebid documentation: tagId, publisherId, bidFloor. * update bid response ttl to 60 seconds. * update Taboola prebid documentation. * update-ttl-passing * Update taboolaBidAdapter_spec.js * add fallback default value in case of null * add semicolons * . * . * . * .. * ... * support-dynamic-endpoint-url * support-dynamic-endpoint-url * support-dynamic-endpoint-url * support-dynamic-endpoint-url * support-dynamic-endpoint-url * support-dynamic-endpoint-url * support-dynamic-endpoint-url * optional-chaining * set netRevenue to true. * fix bid response in case we have multiple impressions * add test * fix lint Co-authored-by: Michael <michael.ziso@taboola.com> Co-authored-by: mikiz <31058500+mikizi@users.noreply.github.com> Co-authored-by: jenny.l <jenny.l@taboola.com> Co-authored-by: jennylt <48404417+jennylt@users.noreply.github.com> Co-authored-by: Ahmad Lobany <ahmad.l@taboola.com> Co-authored-by: ahmadlob <109217988+ahmadlob@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fix handling of multi-impression requests
Other information