Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aso Bid Adapter: support schain #9108

Merged
merged 6 commits into from
Oct 19, 2022
Merged

Conversation

adserver-online
Copy link
Contributor

@adserver-online adserver-online commented Oct 13, 2022

Type of change

  • Feature
  • Code style update
  • Refactoring

Description of change

  1. schain support added
  2. previously internal parameter 'serverUrl' was renamed to 'server' and published
  3. internal parameter 'serverPath' was removed

Other information

Docs PR prebid/prebid.github.io#4075

Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission!

modules/asoBidAdapter.js Outdated Show resolved Hide resolved
modules/asoBidAdapter.js Show resolved Hide resolved
modules/asoBidAdapter.md Outdated Show resolved Hide resolved
@patmmccann patmmccann self-assigned this Oct 14, 2022
@adserver-online
Copy link
Contributor Author

@ChrisHuie could you please kick off tests yet again? they stuck with the same error "Could not find a usable config.yml..."

@patmmccann patmmccann merged commit c709f86 into prebid:master Oct 19, 2022
@adserver-online adserver-online deleted the schain branch January 1, 2023 16:02
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
* SChain support

* manually kick off tests

* Inappropriate remove

* Typo fixed

* Example updated to avoid confusion

Co-authored-by: dev <dev@adsrv.org>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
* SChain support

* manually kick off tests

* Inappropriate remove

* Typo fixed

* Example updated to avoid confusion

Co-authored-by: dev <dev@adsrv.org>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants