Mgid RTD Module : add new RTD module #9120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
patmmccann
reviewed
Oct 21, 2022
Fawke
requested changes
Oct 27, 2022
There was a problem hiding this comment.
Hi @velichkin,
Your code changes are looking good. Please also add the module in the submodules.json. Take a look at an example here
And, we would need you to add more documentation and description in the md file. You also need to create a docs PR in this repo - https://github.com/prebid/prebid.github.io
|
@Fawke I've added module to .submodules.json and made changes in the md file. Also, here is request to docs repo - prebid/prebid.github.io#4081 |
Fawke
approved these changes
Oct 31, 2022
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* Mgid RTD provider * Mgid RTD provider * Mgid RTD provider. Fix endpoint URL * Mgid RTD provider. Fix gdprApplies * Mgid RTD provider. Fix warnings * Mgid RTD provider. Remove unnecessary script * Mgid RTD provider. Add module to .submodules.json * Mgid RTD provider. Changes to .md doc
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* Mgid RTD provider * Mgid RTD provider * Mgid RTD provider. Fix endpoint URL * Mgid RTD provider. Fix gdprApplies * Mgid RTD provider. Fix warnings * Mgid RTD provider. Remove unnecessary script * Mgid RTD provider. Add module to .submodules.json * Mgid RTD provider. Changes to .md doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Mgid Real-time Data Module
Module Name: Mgid Rtd provider
Module Type: Rtd Provider
Maintainer: prebid@mgid.com