-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prebid core: restore bid-level renderer
#9128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -690,7 +690,7 @@ function getPreparedBidForAuction(bid, {index = auctionManager.index} = {}) { | |||
events.emit(CONSTANTS.EVENTS.BID_ADJUSTMENT, bid); | |||
|
|||
// a publisher-defined renderer can be used to render bids | |||
const adUnitRenderer = index.getAdUnit(bid).renderer; | |||
const bidRenderer = index.getBidRequest(bid)?.renderer || index.getAdUnit(bid).renderer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the rendering order of priority if all four are present the following?
Mediatype
Ad unit
Bid
Adapter
And if backup only is specified the order is:
Bid
Adapter
Media type
Ad unit
Correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fowler446 perhaps you've spent the most time on this recently, is this your understanding as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first one of these wins:
- mediaType
- adUnit.bid[]
- adUnit
- bid response
if any of the first 3 say backupOnly
, they will be disregarded as long as the bid response has its own renderer.
Type of change
Description of change
Allow
renderer
to be specified at the bid-level. This was working, although (to the best of my knowledge) undocumented, until 6.9.Other information
Fixes #9126