Prebid core: restore bid-level renderer
#9128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuie
approved these changes
Oct 18, 2022
2 tasks
patmmccann
reviewed
Oct 19, 2022
| @@ -690,7 +690,7 @@ function getPreparedBidForAuction(bid, {index = auctionManager.index} = {}) { | |||
| events.emit(CONSTANTS.EVENTS.BID_ADJUSTMENT, bid); | |||
|
|
|||
| // a publisher-defined renderer can be used to render bids | |||
| const adUnitRenderer = index.getAdUnit(bid).renderer; | |||
| const bidRenderer = index.getBidRequest(bid)?.renderer || index.getAdUnit(bid).renderer; | |||
There was a problem hiding this comment.
Is the rendering order of priority if all four are present the following?
Mediatype
Ad unit
Bid
Adapter
And if backup only is specified the order is:
Bid
Adapter
Media type
Ad unit
Correct?
There was a problem hiding this comment.
@fowler446 perhaps you've spent the most time on this recently, is this your understanding as well?
There was a problem hiding this comment.
The first one of these wins:
- mediaType
- adUnit.bid[]
- adUnit
- bid response
if any of the first 3 say backupOnly, they will be disregarded as long as the bid response has its own renderer.
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Allow
rendererto be specified at the bid-level. This was working, although (to the best of my knowledge) undocumented, until 6.9.Other information
Fixes #9126