AAX Blockmeter RTD Module : Initial Release #9135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
patmmccann
reviewed
Oct 20, 2022
modules/aaxBlockmeterRtdProvider.js
Outdated
|
|
||
| const MODULE = 'aaxBlockmeter'; | ||
| const ADSERVER_TARGETING_KEY = 'atk'; | ||
| const BLOCKMETER_URL = 'https://c.aaxads.com/aax.js'; |
There was a problem hiding this comment.
Please make this a configuration param. If you fall back to it when missing, please lock it to a version. We want publishers using your module to be extremely aware there is js loaded that the project hasn't warranted or reviewed. Please also add an external js disclosure to your docs PR.
There was a problem hiding this comment.
Hi, @patmmccann, have done with the changes please review the changes and docs
ChrisHuie
changed the title
mkendall07
reviewed
Oct 24, 2022
|
|
||
| ## Description | ||
|
|
||
| The module enables publishers to measure traffic coming from visitors using adblockers. |
There was a problem hiding this comment.
I think this requires an account with AAX yes? Might be better to state that here, as it doesn't look like the module itself does much more than load the AAX script.
mkendall07
approved these changes
Oct 24, 2022
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* AAX Blockmeter RTD Module Release * added url in rtd configuration params as params.url * Prebid 7.21.0 release * Increment version to 7.22.0-pre * Prebid core: do not enforce valid size in bid responses (prebid#9138) * Prebid 7.22.0 release * Increment version to 7.23.0-pre * added url in rtd configuration params as params.url Co-authored-by: shubham.si <sinhashubham07@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* AAX Blockmeter RTD Module Release * added url in rtd configuration params as params.url * Prebid 7.21.0 release * Increment version to 7.22.0-pre * Prebid core: do not enforce valid size in bid responses (prebid#9138) * Prebid 7.22.0 release * Increment version to 7.23.0-pre * added url in rtd configuration params as params.url Co-authored-by: shubham.si <sinhashubham07@gmail.com> Co-authored-by: Prebid.js automated release <prebidjs-release@prebid.org> Co-authored-by: Demetrio Girardi <dgirardi@prebid.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
The module enables publishers to measure traffic coming from visitors using adblockers.