Prebid core: allow configurable TTL buffer #9136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jsnellbaker
approved these changes
Oct 24, 2022
|
@dgirardi When you get a chance, please take a look at the recent conflicts. Thanks |
jsnellbaker
added
the
needs 2nd review
ChrisHuie
approved these changes
Oct 27, 2022
ChrisHuie
removed
the
needs 2nd review
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Currently there is a hardcoded 1 second "TTL buffer" used by targeting logic to decide if a bid has expired: a bid with a TTL of 30 seconds is considered expired after 29 seconds.
This adds a
ttlBufferoption accepted as:setConfig({ttlBuffer})that acts as the global default (default is 1 second)requestBids({ttlBuffer})acts as the default within an auctionadUnit.ttlBufferacts on a single ad unit.Other information
Closes #8953
Documentation: prebid/prebid.github.io#4097