Concert Bid Adapter: Update localStorage name-spacing for Concert UID #9158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[RPO-2922] - Add Prebid Unified Token
[RPO-2971] - Add ad slot positioning to payload
* Updates c_uid namespacing to be more specific for concert * fixes unit tests * remove console.log
|
In general, this is bad netizenship. You generate a uuid and set it in the first party domain. Why not check for pubcommonid / sharedid, which is the exact same thing and use that when available and fallback to this when missing? |
|
@jdwieland8282 as fyi; as these examples start to proliferate, should we crack down on them? |
|
Thanks for surfacing this, yes we should, absolutely. |
|
@BrettBlox what are your reservations about checking for and using sharedid? Using a universal open source id namespace (pubcid.org) has many advantages over a bespoke one. |
|
@jdwieland8282 I will look into it. |
* Adds check for sharedId * Updates cookie name * remove trailing comma
|
Updated to check for sharedId. |
patmmccann
reviewed
Nov 7, 2022
|
|
||
| if (sharedId) { | ||
| return sharedId; |
mmoschovas
approved these changes
Nov 8, 2022
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
…prebid#9158) * collect EIDs for bid request * add ad slot positioning to payload * RPO-2012: Update local storage name-spacing for c_uid (prebid#8) * Updates c_uid namespacing to be more specific for concert * fixes unit tests * remove console.log * RPO-2012: Add check for shared id (prebid#9) * Adds check for sharedId * Updates cookie name * remove trailing comma Co-authored-by: antoin <antoin.campbell@voxmedia.com> Co-authored-by: Antoin <antoinfive@gmail.com>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
…prebid#9158) * collect EIDs for bid request * add ad slot positioning to payload * RPO-2012: Update local storage name-spacing for c_uid (#8) * Updates c_uid namespacing to be more specific for concert * fixes unit tests * remove console.log * RPO-2012: Add check for shared id (#9) * Adds check for sharedId * Updates cookie name * remove trailing comma Co-authored-by: antoin <antoin.campbell@voxmedia.com> Co-authored-by: Antoin <antoinfive@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
c_uidwithvmconcert_uidto avoid potential collisions with vendors