Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concert Bid Adapter: Update localStorage name-spacing for Concert UID #9158

Merged
merged 9 commits into from
Nov 8, 2022

Conversation

BrettBlox
Copy link
Contributor

@BrettBlox BrettBlox commented Oct 27, 2022

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • adds check for sharedId falls back to existing method of none exists
  • swaps out localStorage key c_uid with vmconcert_uid to avoid potential collisions with vendors
  • fixes broken tests related to localStorage
  • updates test with new localStorage key name

@patmmccann
Copy link
Collaborator

patmmccann commented Oct 27, 2022

In general, this is bad netizenship. You generate a uuid and set it in the first party domain. Why not check for pubcommonid / sharedid, which is the exact same thing and use that when available and fallback to this when missing?

@patmmccann
Copy link
Collaborator

@jdwieland8282 as fyi; as these examples start to proliferate, should we crack down on them?

@jdwieland8282
Copy link
Member

Thanks for surfacing this, yes we should, absolutely.

@jdwieland8282
Copy link
Member

@BrettBlox what are your reservations about checking for and using sharedid? Using a universal open source id namespace (pubcid.org) has many advantages over a bespoke one.

@BrettBlox
Copy link
Contributor Author

BrettBlox commented Nov 1, 2022

@jdwieland8282 I will look into it.

* Adds check for sharedId

* Updates cookie name

* remove trailing comma
@BrettBlox
Copy link
Contributor Author

Updated to check for sharedId.


if (sharedId) {
return sharedId;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, ty

@mmoschovas mmoschovas merged commit fe23164 into prebid:master Nov 8, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
…prebid#9158)

* collect EIDs for bid request

* add ad slot positioning to payload

* RPO-2012: Update local storage name-spacing for c_uid (prebid#8)

* Updates c_uid namespacing to be more specific for concert

* fixes unit tests

* remove console.log

* RPO-2012: Add check for shared id (prebid#9)

* Adds check for sharedId

* Updates cookie name

* remove trailing comma

Co-authored-by: antoin <antoin.campbell@voxmedia.com>
Co-authored-by: Antoin <antoinfive@gmail.com>
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
…prebid#9158)

* collect EIDs for bid request

* add ad slot positioning to payload

* RPO-2012: Update local storage name-spacing for c_uid (#8)

* Updates c_uid namespacing to be more specific for concert

* fixes unit tests

* remove console.log

* RPO-2012: Add check for shared id (#9)

* Adds check for sharedId

* Updates cookie name

* remove trailing comma

Co-authored-by: antoin <antoin.campbell@voxmedia.com>
Co-authored-by: Antoin <antoinfive@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants