-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zeus Prime RTD Module: initial module release #9165
Conversation
crypto.subtle is only available in secure instances on new browsers, and browserstack runs some tests not in secure mode, so crypto.subtle is undefine. This just creates a mock sublte to avoid this in the tests.
Reading through this, it appears this module sets gam targeting but doesn't make this information available to ssps other than adx? |
@patmmccann That is correct. Prime is inventory that is sold and added to customers GAM account directly. So it's targeting lines in their account, more similar to sponsorship than programmatic. |
Appears to NOT be a rules violation; as it isn't sending key-values to adx or any exchange. Thanks for clarifying. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @PilotConway,
All looks good, just add your module to the modules/.submodules.json
list.
@Fawke Awesome. Just updated the |
* docs(zeusPrime): added zeusPrimeRtdProvider documenation * test: added zeusPrimeRtdProvider tests * feat: added zeusPrime rtd submodule * chore: fix issue with params in the initModule function * chore: lint fixes * chore: lint fixes for tests * test: mock subtle since some tests run insecure crypto.subtle is only available in secure instances on new browsers, and browserstack runs some tests not in secure mode, so crypto.subtle is undefine. This just creates a mock sublte to avoid this in the tests. * test: try to override subtle when it doesnt exist in tests * test: remove subtle restore * chore: added ZeusPrime to .submodules.json
* docs(zeusPrime): added zeusPrimeRtdProvider documenation * test: added zeusPrimeRtdProvider tests * feat: added zeusPrime rtd submodule * chore: fix issue with params in the initModule function * chore: lint fixes * chore: lint fixes for tests * test: mock subtle since some tests run insecure crypto.subtle is only available in secure instances on new browsers, and browserstack runs some tests not in secure mode, so crypto.subtle is undefine. This just creates a mock sublte to avoid this in the tests. * test: try to override subtle when it doesnt exist in tests * test: remove subtle restore * chore: added ZeusPrime to .submodules.json
Type of change
Description of change
This adds an RTD module for Zeus Prime. Zeus Prime client side code requests contextual targeting information for the content on a page and sends the data as a page level key-value in Google AdManager. This is a vendor specific module, as an account and integration with Zeus Prime is required for the API to respond.
Contact: support@zeustechnology.com
To validate, you can provide the following configuration to retrieve a 200 success response from our API:
Note that users of this plugin will only provide gamId, so the hostname and pathname parameters are not documented in the markdown files
Other information
The documentation PR has been submitted as prebid/prebid.github.io#4117