Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeus Prime RTD Module: initial module release #9165

Merged
merged 10 commits into from
Nov 15, 2022

Conversation

PilotConway
Copy link
Contributor

Type of change

  • Feature

Description of change

This adds an RTD module for Zeus Prime. Zeus Prime client side code requests contextual targeting information for the content on a page and sends the data as a page level key-value in Google AdManager. This is a vendor specific module, as an account and integration with Zeus Prime is required for the API to respond.

Contact: support@zeustechnology.com

To validate, you can provide the following configuration to retrieve a 200 success response from our API:

{
  realTimeData: {
    dataProviders: [{
      name: 'zeusPrime',
      waitForIt: false,
      params: {
        gamId: "701", 
        hostname: "www.washingtonpost.com", 
        pathname: "/science/2022/09/26/nasa-dart-mission-asteroid-crash/"
      }
    }]
  },
}

Note that users of this plugin will only provide gamId, so the hostname and pathname parameters are not documented in the markdown files

Other information

The documentation PR has been submitted as prebid/prebid.github.io#4117

crypto.subtle is only available in secure instances on new browsers, and browserstack runs some tests not in secure mode, so crypto.subtle is undefine. This just creates a mock sublte to avoid this in the tests.
@patmmccann
Copy link
Collaborator

Reading through this, it appears this module sets gam targeting but doesn't make this information available to ssps other than adx?

@PilotConway
Copy link
Contributor Author

@patmmccann That is correct. Prime is inventory that is sold and added to customers GAM account directly. So it's targeting lines in their account, more similar to sponsorship than programmatic.

@ChrisHuie ChrisHuie changed the title Add zeusPrimeRtdProvider Zeus Prime RTD Module: initial module release Oct 31, 2022
@ChrisHuie ChrisHuie removed the request for review from ncolletti November 7, 2022 11:07
@ChrisHuie ChrisHuie requested review from Fawke and removed request for mmoschovas November 8, 2022 19:25
@ChrisHuie ChrisHuie assigned Fawke and unassigned mmoschovas Nov 8, 2022
@patmmccann
Copy link
Collaborator

Appears to NOT be a rules violation; as it isn't sending key-values to adx or any exchange. Thanks for clarifying.

Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PilotConway,

All looks good, just add your module to the modules/.submodules.json list.

@PilotConway
Copy link
Contributor Author

@Fawke Awesome. Just updated the .submodules.json.

@Fawke Fawke merged commit 4d6c88d into prebid:master Nov 15, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
* docs(zeusPrime): added zeusPrimeRtdProvider documenation

* test: added zeusPrimeRtdProvider tests

* feat: added zeusPrime rtd submodule

* chore: fix issue with params in the initModule function

* chore: lint fixes

* chore: lint fixes for tests

* test: mock subtle since some tests run insecure

crypto.subtle is only available in secure instances on new browsers, and browserstack runs some tests not in secure mode, so crypto.subtle is undefine. This just creates a mock sublte to avoid this in the tests.

* test: try to override subtle when it doesnt exist in tests

* test: remove subtle restore

* chore: added ZeusPrime to .submodules.json
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
* docs(zeusPrime): added zeusPrimeRtdProvider documenation

* test: added zeusPrimeRtdProvider tests

* feat: added zeusPrime rtd submodule

* chore: fix issue with params in the initModule function

* chore: lint fixes

* chore: lint fixes for tests

* test: mock subtle since some tests run insecure

crypto.subtle is only available in secure instances on new browsers, and browserstack runs some tests not in secure mode, so crypto.subtle is undefine. This just creates a mock sublte to avoid this in the tests.

* test: try to override subtle when it doesnt exist in tests

* test: remove subtle restore

* chore: added ZeusPrime to .submodules.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants