Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triplelift Bid Adapter: prioritize topmostLocation #9178

Merged
merged 5 commits into from
Nov 1, 2022

Conversation

nllerandi3lift
Copy link
Contributor

Type of change

  • Bugfix

Description of change

We are running into similar issues as Kargo as it pertains to DSPs pointing out they are receiving URLs that are not consistent with the actual page of the article. This PR prioritizes topmostLocation over page refererInfo.

Larger question: Should refererInfo.page be prioritizing canonical URLs over the topmostLocation?

Example:

Screen Shot 2022-10-31 at 1 48 22 PM

@ChrisHuie ChrisHuie self-assigned this Nov 1, 2022
@ChrisHuie ChrisHuie merged commit bb5ca05 into prebid:master Nov 1, 2022
JacobKlein26 pushed a commit to nextmillenniummedia/Prebid.js that referenced this pull request Feb 9, 2023
* prioritize topmostlocation

* adds test for topmostlocation / referrer

* cleanup

* delete param after test
jorgeluisrocha pushed a commit to jwplayer/Prebid.js that referenced this pull request May 23, 2023
* prioritize topmostlocation

* adds test for topmostlocation / referrer

* cleanup

* delete param after test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants