-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Captify RTD Submodule: Initial release #9180
Captify RTD Submodule: Initial release #9180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but there are a few things.
- Missing a Docs PR.
- I see that you're currently only adding the segment data for Appnexus bidder. Is is possible to make this value available in a more generic place? For example, like the ortb2 object? All bidders can read it then...BTW, Appnexus bid adapter also supports reading from ortb2 keywords now.
- You would like to add your module to
.submodules.json
file. Example
Hey @Fawke, thanks for the review! I'm not really sure we want now to create this as ortb2 keywords, we probably can improve this in future releases, if future proof module will work initially as we expect. Currently we tested this together with Xandr (Appnexus) and I don't want to really change the protocol in last moment. I will check this with Xandr for future releases. Will add documentation PR soon. Regards, |
* Captify Live-classification Rtd Submodule * Fix code-review comments
* Captify Live-classification Rtd Submodule * Fix code-review comments
Hi @captify-osoldatov ; we're not able to carry Captify forward into Prebid 8 without the changes requested above and on #8596 . Since it seems your adapter only handles Xandr and no other adapters, it is better to remove rather than just remove that code block? |
Hi @patmmccann! It's ok to drop it then; For now, I wouldn't be able to provide a quick fix for that. We will better integrate from scratch as soon as we have a new setup and it's tested. Meanwhile, we will still be able to integrate with the earlier Prebid version, so should be fine. |
@captify-osoldatov we are happy to provide assistance and point you to demonstrations to get you back integrated quickly! |
Thank you @patmmccann ! Have a nice day) |
Type of change
Description of change
The RTD submodule enables publishers to use Captify's Live-classification technology via Prebid.js
Contact email of the module maintainer: prebid@captify.tech