gumgum Bid Adapter: support coppa config #9192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adapter ADJS-1227-add-coppa-flag-to-gumgum-adapter
patmmccann
approved these changes
Nov 3, 2022
patmmccann
reviewed
Nov 3, 2022
| @@ -294,6 +294,7 @@ function buildRequests(validBidRequests, bidderRequest) { | |||
| const gdprConsent = bidderRequest && bidderRequest.gdprConsent; | |||
| const uspConsent = bidderRequest && bidderRequest.uspConsent; | |||
| const timeout = config.getConfig('bidderTimeout'); | |||
| const coppa = config.getConfig('coppa') === true ? 1 : 0; | |||
There was a problem hiding this comment.
fwiw the line above this is the wrong way to get timeout; the timeout from requestBids can be overridden in https://docs.prebid.org/dev-docs/publisher-api-reference/requestBids.html
For example, I think CafeMedia always overrides.
There was a problem hiding this comment.
@patmmccann thanks for the review and for catching this issue. I'll make a ticket to review if we're using it or not and make the necessary corrections based on those findings.
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* ADJS-1227-add-coppa-flag-to-gumgum-adapter * added tests for coppa config for gumgumBidAdapter Co-authored-by: John Bauzon <john.bauzon@gumgum.com>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* ADJS-1227-add-coppa-flag-to-gumgum-adapter * added tests for coppa config for gumgumBidAdapter Co-authored-by: John Bauzon <john.bauzon@gumgum.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Added ability to send coppa flag to gumgum ad server if set to true