SmartyTech Bid Adapter : initial adapter release #9196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuie
changed the title
|
Hi @preved-medved , your bidder does not satisfy the requirement of having at least 80% test coverage. Please be sure to increase code coverage. To see the coverage run first and then |
|
Hi @musikele. Fixed, sorry for that. |
musikele
suggested changes
Nov 9, 2022
modules/smartytechBidAdapter.js
Outdated
| return bidObject; | ||
| }, | ||
|
|
||
| postRequest(endpoint, data) { |
There was a problem hiding this comment.
I don't understand the need for this method, it doesn't seem to be called by anybody
|
@preved-medved You may open a PR in the headerbid-expert repository to have their adapter recognized by the Headerbid Expert extension. The PR should be to the bidder patterns file, adding an entry with their adapter's name and the url the adapter uses to send and receive bid responses. |
|
Docs PR prebid/prebid.github.io#4125 |
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* Add new bid adapter for company smartytech * change domain to prod * update unit tests * remove unused code * remove unused code
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* Add new bid adapter for company smartytech * change domain to prod * update unit tests * remove unused code * remove unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information