Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nextmillenium bid adapter: Collection of statistics data #9265

Merged
merged 27 commits into from
Dec 12, 2022
Merged

Nextmillenium bid adapter: Collection of statistics data #9265

Changes from 24 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
b00c661
changed name company
mhlm May 31, 2019
38081ff
changed name company in test
mhlm Jun 3, 2019
15bc5fd
Merge pull request #1 from prebid/master
mhlm Oct 8, 2019
7c7d413
Merge branch 'prebid:master' into master
mhlm Mar 21, 2022
4a3926e
Added processing of a new group_id parameter
mhlm Mar 21, 2022
0665078
Added processing of a new group_id parameter
mhlm Mar 21, 2022
3db3ac5
changed check parameters
mhlm Mar 25, 2022
18dff75
fixed lint remarks
mhlm Mar 25, 2022
df8a27c
added test
mhlm Mar 29, 2022
21fc771
fixed bug - lint
mhlm Mar 29, 2022
81b90a7
changed test
mhlm Mar 29, 2022
193a5d6
changed test - 2
mhlm Mar 29, 2022
2445c0b
fixed bug - adapter
mhlm Mar 29, 2022
26bfc7d
Merge branch 'prebid:master' into master
mhlm Jul 6, 2022
77454b7
added logic for getting ad impressions
mhlm Jul 6, 2022
d7f83b0
merged
mhlm Nov 17, 2022
9fed5d1
Collecting timeouts data
mhlm Nov 21, 2022
db0a0a0
Collecting resaponses and no_bids data
mhlm Nov 21, 2022
87c81fe
changed a name function
mhlm Nov 21, 2022
5a0a957
added event bidRequested
mhlm Nov 23, 2022
39ed0f9
added event bidRequested
mhlm Nov 23, 2022
8231065
added function initialization events
mhlm Nov 23, 2022
33f3e1a
fixed bug
mhlm Nov 23, 2022
83ca951
save
mhlm Nov 23, 2022
0e93c31
added tests
mhlm Nov 29, 2022
3560892
Added processing of the disabledSendingStatisticData parameter, which…
mhlm Dec 5, 2022
463aa57
changed the name of the variables
mhlm Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion modules/nextMillenniumBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import { getRefererInfo } from '../src/refererDetection.js';
const BIDDER_CODE = 'nextMillennium';
const ENDPOINT = 'https://pbs.nextmillmedia.com/openrtb2/auction';
const TEST_ENDPOINT = 'https://test.pbs.nextmillmedia.com/openrtb2/auction';
const REPORT_ENDPOINT = 'https://report2.hb.brainlyads.com/statistics/metric';
const SYNC_ENDPOINT = 'https://cookies.nextmillmedia.com/sync?';
const TIME_TO_LIVE = 360;
const VIDEO_PARAMS = [
Expand All @@ -31,9 +32,13 @@ const VIDEO_PARAMS = [

const EXPIRENCE_WURL = 20 * 60000;
const wurlMap = {};
cleanWurl();

events.on(CONSTANTS.EVENTS.BID_TIMEOUT, eventHandler(CONSTANTS.EVENTS.BID_TIMEOUT));
events.on(CONSTANTS.EVENTS.BID_RESPONSE, eventHandler(CONSTANTS.EVENTS.BID_RESPONSE));
events.on(CONSTANTS.EVENTS.BID_REQUESTED, eventHandler(CONSTANTS.EVENTS.BID_REQUESTED));
events.on(CONSTANTS.EVENTS.NO_BID, eventHandler(CONSTANTS.EVENTS.NO_BID));
events.on(CONSTANTS.EVENTS.BID_WON, bidWonHandler);
cleanWurl();

export const spec = {
code: BIDDER_CODE,
Expand Down Expand Up @@ -328,6 +333,30 @@ function getWurl({auctionId, requestId}) {
return wurlMap[key] && wurlMap[key].wurl;
}

function eventHandler(eventName) {
const _eventHandler = getEventHandler(eventName);
if (eventName == CONSTANTS.EVENTS.BID_TIMEOUT) {
return bids => {
if (!Array.isArray(bids)) return

for (let bid of bids) {
_eventHandler(bid);
};
}
};

return _eventHandler;
}

function getEventHandler(eventName) {
return bid => {
const bidder = bid.bidder || bid.bidderCode;
if (bidder != BIDDER_CODE) return;

triggerPixel(`${REPORT_ENDPOINT}?event=${eventName}&bidder=${bidder}&source=pbjs`);
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patmmccann I corrected the code and now all tests pass. I don't know how to test this new functionality, all the added code does is set an event handler for the bidRequested, bidResponse, noBid and bidTimeout events. Internally, it generates a url and sends data to the server via the utils.triggerPixel function.
If you still insist on tests, I will try to add them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patmmccann Can you please tell me what you think about it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no unit tests on this pr, we're hesitant to assign a reviewer before the pr is complete

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeking some feedback from others on how to test, will get back to you


function bidWonHandler(bid) {
const {auctionId, requestId} = bid;
const wurl = getWurl({auctionId, requestId});
Expand Down