Adagio Bid Adapter: external script loading improvement #9296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfo
approved these changes
Nov 29, 2022
patmmccann
requested changes
Nov 29, 2022
| @@ -38,7 +38,8 @@ const LOG_PREFIX = 'Adagio:'; | |||
| const FEATURES_VERSION = '1'; | |||
| export const ENDPOINT = 'https://mp.4dex.io/prebid'; | |||
| const SUPPORTED_MEDIA_TYPES = [BANNER, NATIVE, VIDEO]; | |||
| const ADAGIO_TAG_URL = 'https://script.4dex.io/localstore.js'; | |||
| const ADAGIO_TAG_URL = 'https://script.4dex.io/adagio.js'; | |||
There was a problem hiding this comment.
please lock this to a version and update what is available in https://github.com/Prebid-org/prebid-js-external-js-adagio-io/tree/master/dist
There was a problem hiding this comment.
Hi @patmmccann, we make regular updates, we can't lock to a version. We always work this way, is something changed?
update what is available in…
Do you want I make some cleanup?
There was a problem hiding this comment.
please see #5804 ; as part of Prebid 5, Criteo locked their load to a version. Also, the private repo has unminified code.
|
closing as stale @osazos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR is about to ensure our external script is loaded when we cannot use localStorage.
Note that we DON'T use LocalStorage, the script is loaded and executed, but it is never cached.