Permutive RTD Module: migrate appnexus to ortb2 #9630

AntonioGargaro · 2023-03-07T16:24:21Z

Type of change

Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other

Description of change

Adds additional keywords to ortb2 that enables us to migrate away from appnexus' special handlings.

Other information

In a recent #9236 (comment), our special bid.params handlings were put on notice of being removed if we didn't address the issue by the end of Q2. This PR migrates appnexus handlers We've coordinated with each partner on the best place to make data available in ortb2 that each bidder expects.

patmmccann · 2023-03-08T18:13:14Z

modules/permutiveRtdProvider.js

@@ -251,17 +273,6 @@ function getDefaultBidderFn (bidder) {
    return [...new Set([...ac, ...ssp])]
  }
  const bidderMap = {
-    appnexus: function (bid, data, acEnabled) {


does this make the aliasMap code above unnecessary?

~~You are correct, I missed that!~~
Actually, we'll have to retain this for backwards compatibility as publishers can set custom functions per bidder and pass that into the RTD via config.

This reverts commit e1fa634.

* upstream/master: Prebid Server adapter: fledge support (prebid#9342) Taboola Bid Adapter: resolve AUCTION_PRICE macro (prebid#9735) Revert "IntentIQ Analytics Module : initial release (prebid#9322)" (prebid#9734) IntentIQ Analytics Module : initial release (prebid#9322) Increment version to 7.44.0-pre Prebid 7.43.0 release Core: allow restriction of cookies / localStorage through `bidderSettings.*.storageAllowed` (prebid#9660) Add 9 Dots Media alias (prebid#9699) Smaato: Adapters that accept geolocation data from bid parameters should also accept it from ortb2.(device|user).geo (prebid#9676) (prebid#9725) Adloox AdServer Video : lengthen test timeouts (prebid#9728) RTBHouse Bid Adapter: change `source.tid` to contain `auctionId` and populate imp-level `ext.tid` (prebid#9726) chore: update `getAudiencesAsBidderOrtb2` implementation and test (prebid#9720) CORE: allow to disable setting the pbjs global variable (prebid#9568) Display.io Bid Adapter: ad request parameters renaming, user session saving (prebid#9553) CORE: add bid to winningBids when marking as used (prebid#9612) Concert Bid Adapter: enable support for GPP consent and remove user sync (prebid#9700) Sonobi Bid Adapter: add IntentIq Id (prebid#9649) added fix and support for multibid module (prebid#9602) Update Permutive RTD documentation (prebid#9697) Adkernel Bid Adapter: add adlive.io alias (prebid#9714) FPD Enrichment: use low entropy method by default to fetch user agent data (prebid#9711) GumGum Bid Adapter : send gpp data in bidrequest (prebid#9707) Adagio Bid Adapter : add new params `splitKeyword` and `dl` to bidRequest payload (prebid#9694) fix lint and test failures Increment version to 7.43.0-pre Prebid 7.42.0 release Fluct Bid Adapter: add user sync support (prebid#9651) VIS.X fix onTimeout data (prebid#9657) ShowHeroes Bid Adapter: added support for USP (prebid#9681) Core: improve FPD enrichment (prebid#9659) changed the URL (prebid#9698) Permutive RTD Module: migrate appnexus to ortb2 (prebid#9630) Disable describe.only and it.only (prebid#9693) DistroScale bidder enhancement (prebid#9641) minutemediaplus Bid Adapter - pass gpp, sua and bid data to server. (prebid#9637) LiveIntent UserId module: update LiveConnect dependency (prebid#9672) Criteo Bid Adapter: reinforce adomain type in case of missmatch (prebid#9687) SmartyTech Bid Adapter : add size parameters (prebid#9692) Revert "Nativo Bid Adapter: adding UserId support (prebid#9583)" (prebid#9691) GDPR consent management: accept static config without `getTCData` (prebid#9664) Kulturemedia Bid Adapter: New Adapter (prebid#9613) Nativo Bid Adapter: adding UserId support (prebid#9583) Underdog Media Bid Adapter: Switch request to method to POST (prebid#9547) ZetaGlobalSsp: provide schain (prebid#9678) Next Millennium Bid Adapter : added `imp[].id` required parameter for openrtb 2.5 request. (prebid#9675) Increment version to 7.42.0-pre Prebid 7.41.0 release DFP video adserver module: set `description_url` to pub's URL by default; do not skip setting it if `cache.url` is set (prebid#9665) support the timeout parameter in the conversant adapter (prebid#9673) Browsi Bid Adapter: initial release (prebid#9562) feat(permutiveRtd): add `ix` and custom cohort `ortb2.user.data` (prebid#9631) Freewheel SSP Adapter: add prebid version in ad request (prebid#9667) Yandex Bid Adapter: (prebid#9604) Bump webpack from 5.74.0 to 5.76.0 (prebid#9668) Deleted the default empty string from userConsent argument in the module's init-function. (prebid#9663) AdUp Technology bid adapter: avoid modification of bid request (prebid#9656) NoBid Bid Adapter: support for Floors (prebid#9635) Freewheel SSP Bid Adapter : support userIdAsEids (prebid#9655) Missena: add userEids, add network and cpm to tracking (prebid#9645) IX Bid Adapter: update additional consent field (prebid#9650) Aduptech Bid Adapter : add GVLID (prebid#9658) Core: make video cache timeout configurable (prebid#9578) Delete flocIdSystem.js (prebid#9652) TheMediaGrid Bid Adapter : support gpp (prebid#9629) Stv Bid Adapter : initial adapter release (prebid#9533) CleanMediaNet Bid Adapter : add userid support and update testing (prebid#9608) Update creative.html (prebid#9648) PubWise Bid Adapter: support video and improve tests (prebid#9576) Increment version to 7.41.0-pre Prebid 7.40.0 release Rubicon Bid Adapter: add size 1x2 (prebid#9644) main>modules\neuwoRtdProvider.js > apiUrl format handling improved, removed unnecessary parameter integrationExamples\gpt\neuwoRtdProvider_example.html > fixed render-step handling on warning (prebid#9646) Core: fix native render when adUnits defines `mediaTypes.native.ortb` but adapter replies with "legacy" native bid (prebid#9638) kueezRtb Bid Adapter: pass sua data to server. (prebid#9643) update Mediago & Discovery BidAdapter:remove size filter (prebid#9585) Permutive RTD Module: migrate magnite to ortb2 (prebid#9555) Vidazoo Bid Adapter: pass sua params. (prebid#9636) ADJS-1271-send-envelope-param-for-lexicon (prebid#9634) Nexx360 Bid Adapter: native support added and ortbConverter usage (prebid#9626) PBjs Core: do not rely on an extendable `window.Promise` (prebid#9558) TheMediaGrid Bid Adapters : do not use jwp segments from bid.rtd field (prebid#9627) read video size from playerSize (prebid#9625) Lemma Digital Bid Adapter : initial adapter release (prebid#9532) smallfix on response validation (prebid#9623) Updated adf adapter to support native with type; use ortb request for natives (prebid#9616) kargo adapter - adding prebid version to requests (prebid#9620) Rubicon bid adapter: remove pchain support (prebid#9621) trigger build revert tag out markWinningBidAsUsed entirely remove unnecessary feature tag tag out ORTB video conversion utils tag out video-related code in native.js tag out video-related code in renderAd replace callPrebidCache with getHook result tag out adpod-related logic Define "VIDEO" compile time feature flag

* fix(permutiveRtd): migrate appnexus to ortb2 keywords * test(permutiveRtd): remove outdated appnexus test * fix(permutiveRtd): remove bidder specific logic for keywords * fix(permutiveRtd): remove alias map in legacy segment setting * Revert "fix(permutiveRtd): remove alias map in legacy segment setting" This reverts commit e1fa634.

* Pubmatic Bid Adapter: Removed logic to append JW player data to the "dctr" param (#9169) * removed logic to append jw data to dctr param * removed unneeded code * removed extra html page for testing * Prebidmanager Analytics Adapter: reduce requests size (#9566) * Prebidmanager analytics adapter: reduce requests size * Update prebidmanagerAnalyticsAdapter.js * Update prebidmanagerAnalyticsAdapter.js --------- Co-authored-by: Patrick McCann <pmccann@cafemedia.com> * Prebid 7.38.0 release * Increment version to 7.39.0-pre * Resetdigital bid Adapter: add fields and suport for coppa (#9400) * Resetdigital Bid Adapter: Add custom fields to bid request and GDRP support * fixing comments * fix bidfloor settings * get kewords from request and site meta tag" * fix bild errors --------- Co-authored-by: nicolas taglienti <nicotaglienti@gmail.com> * Renamed cpexId to czechAdId (#9433) * remove outdated lgtm shield (#9535) * Rubicon Bid Adapter: add native support (#9574) * add support for native * wrap native tests around FEATURES.NATIVE * remove commented out code * HB-16092 support multiformat parameter * do not generate imp if has only banner media type * check banner bid type only if mediaTypes.banner * new multiformat logic * bidonmultiformat * fixes: do not set empty keywords; better behavior for floors. * currency is always added * remove prorperties that are already set by ortb --------- Co-authored-by: Michele Nasti <michele@rtk.io> * revert * Missena: add format params and onBidWon pixel (#9517) * Alkimi Bid Adapter : add multisize multiformat (#9575) * Alkimi bid adapter * Alkimi bid adapter * Alkimi bid adapter * alkimi adapter * onBidWon change * sign utils * auction ID as bid request ID * unit test fixes * change maintainer info * Updated the ad unit params * features support added * transfer adUnitCode * transfer adUnitCode: test * AlkimiBidAdapter getFloor() using * ALK-504 Multi size ad slot support * ALK-504 Multi size ad slot support --------- Co-authored-by: Alexander <32703851+pro-nsk@users.noreply.github.com> Co-authored-by: Alexander Bogdanov <akascheev@asteriosoft.com> Co-authored-by: Alexander Bogdanov <abogdanov@asteriosoft.com> Co-authored-by: motors <motors@live.ru> Co-authored-by: Kalidas Engaiahraj <kalidas@alkimiexchange.com> Co-authored-by: mik <mihanikw2g@gmail.com> * Revert "Rubicon Bid Adapter: add native support (#9574)" (#9599) This reverts commit 99ffff27e11b2c984dad2dc8256e930d548f5535. * Prebid Core: emit seatnonbid from prebid server (#9453) * Parse and emit seatnonbid from server * Fix testing adjustments * Use onResponse for seatNonBids * Fix linting error * Emit to auction and add unit tests * Use optional property chaining * returnallbidstatus * fix varname in spec * Tappx Bid Adapter: Fix/os and vendor (#9468) * Fix: creating host correctly when http or https are added from the beginning * Fix :: Changed double quotes for single quotes * Fix :: Getting the full page URL * Fix :: Changed order params * Fix :: Replaced quotes from double to simple * Fix :: Adapting format to lint * Remove TODO comment * Added more controls * camelcase fix * Changed test * Remove "inIframe" util * Fix: solved error getOs and created getVendor functions * Fix: Solved CircelCI format problems --------- Co-authored-by: Jordi Arnau <jarnau@tappx.com> Co-authored-by: ruben_tappx <rcaparros@tappx.com> * NovatiqidSystem UserId Module: Fix async json response (#9601) * Novatiq snowflake userId submodule Novatiq snowflake userId submodule initial release * change request updates added novatiq info /modules/userId/userId.md added novatiq info /modules/userId/eids.md added novatiq eids /modules/userId/eids.js added novatiq module in /modules/.submodules.json removed unnecessary value from getId response * Update novatiqIdSystem_spec.js removed unnecessary srcid value * Update novatiqIdSystem.md Novatiq ID System: updated novatiq snowflake ID description * use the sharedId if available and configured * updated docs * test changes * defensive code not required * Use the prebid storage manager instead of using native functions * doc changes * trailing spaces * Allow configuration of the sync URL and to allow callbacks for specific custom partner integrations * update documentation * attempt to fix firefox test timeout * include the AIB Vendor Id * fix async response --------- Co-authored-by: novatiq <79258366+novatiq@users.noreply.github.com> * ID5 Adapter: protect against local storage writing without consent (#9587) * id-6129: don't write to local storage without consent * id-6129: clean up * id-6129: clean up * id-6129: refactor * id-6129: use deepAccess * id-6129: unit tests * id-6129: logging * id-6129: improve log * GDPR (consentManagement): fix `actionTimeout` behavior (#9600) * GDPR (consentManagement): fix `actionTimeout` behavior * Add test case for actionTimeout = 0 * VisibleMeasures Bid Adapter : initial adapter release (#9488) * add VisibleMeasures adapter * fix test * PubMatic Bid Adapter and Analytics Adapter : Added support for dchain and metadata (#9579) * only send hb_acat if acat is present * removed a couple unneeded files * reverted a few more unneeded changes * Changes to support dchain object. And passing metadata in logger log including dchain * Added missing code * Added the missing metadata in PubaticBidAdapter * Revrting the changes from jlquaccia/UOE-8728 * Test cases added for metadata and dchain --------- Co-authored-by: jlquaccia <jlquaccia@gmail.com> * Prebid Core: Only Send Optional Category Targeting Key if ACAT is Present on Page (#9530) * only send hb_acat if acat is present * removed a couple unneeded files * reverted a few more unneeded changes * updated acat test * Eplanning Bid Adapter : cut url when url size greater than 255 (#9606) * cut url whit url length is greater than 255 * Fix lint * TL-35335: Cast playbackmethod as array (#9610) * Relevad RTD Module : initial release (#9454) * Added implementation of the Relevad Real-Time Data Provider * removed bidder from the testing HTML file * Addressed reviewer's request w.r.t. removing bidder-specific handling' * set page url * Addressed code review comments: fixed email address, added description of ORTB attributes we pass to the bidders * Addressed code review comments --------- Co-authored-by: Relevad <> * AMX Bid Adapter: add gpp support (#9556) * AMX bid adapter: add gpp support, cookie sync improvements * fix unit tests * Rubicon bid adapter: native support (#9605) * add support for native * wrap native tests around FEATURES.NATIVE * remove commented out code * HB-16092 support multiformat parameter * do not generate imp if has only banner media type * check banner bid type only if mediaTypes.banner * new multiformat logic * bidonmultiformat * fixes: do not set empty keywords; better behavior for floors. * currency is always added * remove prorperties that are already set by ortb * fix tests --------- Co-authored-by: Michele Nasti <michele@rtk.io> * [Video Module] Bugfix: Allow publishers to override video params (#9611) * allows publisher to override video params * passes proper config to ima * TTD BId Adapter: Support bidfloor bidding parameter (#9607) * rbc-OPATH-367: support bidfloor bidding parameter * rbc-OPATH-367-added-tests --------- Co-authored-by: robert.charlton <robert.charlton@thetradedesk.com> Co-authored-by: robert-charlton-ttd <124640243+robert-charlton-ttd@users.noreply.github.com> * Add: banner requests for ViouslyBidAdapter (#9513) * Prebid 7.39.0 release * Increment version to 7.40.0-pre * Relevad RTD adapter: updated contact email (#9618) * Added implementation of the Relevad Real-Time Data Provider * removed bidder from the testing HTML file * Addressed reviewer's request w.r.t. removing bidder-specific handling' * set page url * Addressed code review comments: fixed email address, added description of ORTB attributes we pass to the bidders * Addressed code review comments * Updated contact email address --------- Co-authored-by: Relevad <> * Remove references to deprecated cookies (#9619) * ImproveDigital Bid Adapter: minor bug fixes (#9614) * Improve Digital adapter: publisher endpoint, addtl consent, syncs (#14) - add bidders to sync url when extend mode enabled - set ConsentedProvidersSettings when extend mode enabled - dynamically generated AD_SERVER_URL when publisherId available * Code refactored * Minor changes * Fix an issue where uppercase </SCRIPT> tags broke the JS on page, as they were not properly escaped * fixed tests --------- Co-authored-by: Faisal Islam <93644923+faisalvs@users.noreply.github.com> Co-authored-by: Faisal Islam <faisal.islam@vivacomsolutions.com> Co-authored-by: Jozef Bartek <j.bartek@improvedigital.com> Co-authored-by: Jozef Bartek <31618107+jbartek25@users.noreply.github.com> * trigger build * Rubicon bid adapter: remove pchain support (#9621) * Rubicon adapter - remove pchain support * removing pchain from unit tests * kargo adapter - adding prebid version to requests (#9620) * Updated adf adapter to support native with type; use ortb request for natives (#9616) Co-authored-by: Justas Pupelis <justas.pupelis@adform.com> * smallfix on response validation (#9623) Co-authored-by: Vasyl Rishko <vasyl.rishko@smartyads.com> * Lemma Digital Bid Adapter : initial adapter release (#9532) * Added lemmadigital bid adapter code * update documentation for banner ad request * Made review changes for video params reads first * read video size from playerSize (#9625) Co-authored-by: Love Sharma <love.sharma@indexexchange.com> * TheMediaGrid Bid Adapters : do not use jwp segments from bid.rtd field (#9627) * TheMediaGrid: do not use jwp segments from bid.rtd field * TheMediaGridNM: do not use jwp segments from bid.rtd field * PBjs Core: do not rely on an extendable `window.Promise` (#9558) * Core: do not rely on an extendable `window.Promise` * Add test cases for empty-input all / allSettled * Nexx360 Bid Adapter: native support added and ortbConverter usage (#9626) * native added and ortb converter usage * Update nexx360BidAdapter.js * ADJS-1271-send-envelope-param-for-lexicon (#9634) Co-authored-by: John Bauzon <john.bauzon@gumgum.com> * Vidazoo Bid Adapter: pass sua params. (#9636) * feat(module): multi size request * fix getUserSyncs added tests * update(module): package-lock.json from master * feat(module): VidazooBidAdapter - send top query params to server * feat: pass sua params to bid request. --------- Co-authored-by: Udi Talias <udi.talias@gmail.com> Co-authored-by: roman <shmoop207@gmail.com> * Permutive RTD Module: migrate magnite to ortb2 (#9555) * feat(permutiveRtd): migrate rubicon targeting to ortb2 * perf(permutiveRtd): prevent redundant cohort reads and updates * fix(permutiveRtd): enable debugger logs for ortb2 updates * fix(permutiveRtd): provide identity bidder fn fallback * test(permutiveRtd): update params to follow refactor * fix(permutiveRtd): prevent multiple targeting updates once in realtime * fix(permutiveRtd): require `waitForIt` and permutive to be false to complete immediately * fix(permutiveRtd): remove bidder specific logic * update Mediago & Discovery BidAdapter:remove size filter (#9585) * Mediago Bid Adapter:new adapter * remove console * change spec file to fix CircleCI * change spec file to fix CircleCI * change spec file * Update mediagoBidAdapter.js * Update mediagoBidAdapter.js * rerun CurcleCi * update mediagoBidAdapter * update discoveryBidAdapter * Discovery Bid Adapter : parameter updates * Mediago Bid Adapter : parameter updates * Mediago Bid Adapter : code style format * rerun circleci * rerun circleci * rerun circleci * rerun circleci * Update mediagoBidAdapter & discoveryBidAdapter:report eids to server * Update mediagoBidAdapter & discoveryBidAdapter:report eids to server * update Mediago & Discovery BidAdapter:remove size filter * update Mediago & Discovery BidAdapter:code format * update Mediago & Discovery BidAdapter:code format * update Mediago & Discovery BidAdapter:add param in banner format * update mediago & discovery:first party data * update mediago & discovery:first party data * update mediago & discovery:first party data --------- Co-authored-by: BaronYu <baronwei11@gmail.com> * kueezRtb Bid Adapter: pass sua data to server. (#9643) * Core: fix native render when adUnits defines `mediaTypes.native.ortb` but adapter replies with "legacy" native bid (#9638) * Fix conversion to ortb native * Add natvie ortb response to message payload when the adUnit uses native ortb * main>modules\neuwoRtdProvider.js > apiUrl format handling improved, removed unnecessary parameter integrationExamples\gpt\neuwoRtdProvider_example.html > fixed render-step handling on warning (#9646) * Rubicon Bid Adapter: add size 1x2 (#9644) * Added support for the Price Floors Module * Use the ad server's currency when getting prices from the floors module * Default to USD if the ad server's currency can't be retrieved * Set the default currency at the right place * Added tests and made a minor change in how device width and height are calculated * Only include flrCur when ad requests contain floors * Added 1x2 (524) size to Rubicon adapter --------- Co-authored-by: msmeza <moises@livewrapped.com> * Prebid 7.40.0 release * Increment version to 7.41.0-pre * PubWise Bid Adapter: support video and improve tests (#9576) * updates to PubWise bidder * updates for video outstream processing * update pubwise bidder to 0.3.0 * add testing updates * update device detection * Update creative.html (#9648) * CleanMediaNet Bid Adapter : add userid support and update testing (#9608) * Update cleanmedianetBidAdapter.js * Update cleanmedianetBidAdapter.md * Revert "Update cleanmedianetBidAdapter.md" This reverts commit f7d3e50ccc4eb8c846ab92ab5bf8704351a11c2b. * Revert "Update cleanmedianetBidAdapter.js" This reverts commit 861230608f744e3b35a8bc939f947a43afe05e8c. * Update cleanmedianetBidAdapter_spec.js * Update cleanmedianetBidAdapter.md * Update cleanmedianetBidAdapter.js * Updated config.yml * Updated config.yml * kick off tests * Update cleanmedianetBidAdapter.md * Update cleanmedianetBidAdapter.js EndPoint Update * Update cleanmedianetBidAdapter.js --------- Co-authored-by: Moshe Moses <moshe.moses@gmail.com> Co-authored-by: moses <moses@gamoshi.com> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> * Stv Bid Adapter : initial adapter release (#9533) * initial commit * adapted buildRequests function * refinement pfilter and bcat * refinement * adapted tests for isBidRequestValid,buildRequests * adaptations for test * finished building stvBidAdapter.js * finished: ran tests, coverage 99% * update: rename w->srw, h->srh * adapt stvBidAdapter.md * remove dspx from stv adapters * some changes (missing: getUserSyncs, but is the same as in radsBidAdapter) * added checks in getUserSyncs; ran tests --------- Co-authored-by: theo_ <theo_@IDEA3> * TheMediaGrid Bid Adapter : support gpp (#9629) * TheMediaGrid: support gpp * TheMediaGrid: review fixes * TheMediaGrid: fix merge typo * TheMediaGrid: minor fix --------- Co-authored-by: Stanyslav Glubyshev <sglubyshev@iponweb.net> * Delete flocIdSystem.js (#9652) * Core: make video cache timeout configurable (#9578) * Aduptech Bid Adapter : add GVLID (#9658) * Add GVLID to adup tech Axel Springer Teaser Ad GmbH (647) is the vendor running this bid adatper * fix lint error --------- Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> * IX Bid Adapter: update additional consent field (#9650) * feat: update additional consent location [PB-351] * feat: update additional consent field [PB-351] --------- Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> * Missena: add userEids, add network and cpm to tracking (#9645) * Freewheel SSP Bid Adapter : support userIdAsEids (#9655) * FreeWheel add floor price * FreeWheel code update * FreeWheel-SSP-Adapter: Update to use Vast 4.2 by default * FreeWheel-SSP-Adapter add userIdAsEids support * Freewheel-SSP-Adapter add test for eids * NoBid Bid Adapter: support for Floors (#9635) * Enable supplyChain support * Added support for COPPA * rebuilt * Added support for Extended User IDs. * Added support for the "meta" attribute in bid response. * Added support for Floors to the NoBid Prebid Adapter. * Delete .project Removed IDE file. * Delete .jsdtscope Removed IDE file. * Delete org.eclipse.wst.jsdt.ui.superType.container Removed IDE file. * Delete org.eclipse.wst.jsdt.ui.superType.name Removed IDE file. * Delete a Delete strange file. * Delete nobidBidAdapter.js.orig Delete file not needed. --------- Co-authored-by: Reda Guermas <reda.guermas@nobid.io> * AdUp Technology bid adapter: avoid modification of bid request (#9656) * Deleted the default empty string from userConsent argument in the module's init-function. (#9663) * Bump webpack from 5.74.0 to 5.76.0 (#9668) Bumps [webpack](https://github.com/webpack/webpack) from 5.74.0 to 5.76.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](https://github.com/webpack/webpack/compare/v5.74.0...v5.76.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Yandex Bid Adapter: (#9604) * added support media-type native * fixed gdpr parameters * changed endpoint url Co-authored-by: Taras Saveliev <t-saveliev@yandex-team.ru> * Freewheel SSP Adapter: add prebid version in ad request (#9667) * FreeWheel add floor price * FreeWheel code update * FreeWheel-SSP-Adapter: Update to use Vast 4.2 by default * FreeWheel-SSP-Adapter add userIdAsEids support * Freewheel-SSP-Adapter add test for eids * Freewheel SSP Adapter: add prebid version in request * code cleanup * feat(permutiveRtd): add `ix` and custom cohort `ortb2.user.data` (#9631) * Browsi Bid Adapter: initial release (#9562) * browsiBidAdapter * browsiBidAdapter-pr-check-ids-are-truthy-and-use-video-sizes * browsiBidAdapter-pr-spec-fix * support the timeout parameter in the conversant adapter (#9673) Co-authored-by: johwier <john.wier@epsilon.com> * DFP video adserver module: set `description_url` to pub's URL by default; do not skip setting it if `cache.url` is set (#9665) * Prebid 7.41.0 release * Increment version to 7.42.0-pre * Next Millennium Bid Adapter : added `imp[].id` required parameter for openrtb 2.5 request. (#9675) * changed name company * changed name company in test * Added processing of a new group_id parameter * Added processing of a new group_id parameter * changed check parameters * fixed lint remarks * added test * fixed bug - lint * changed test * changed test - 2 * fixed bug - adapter * added logic for getting ad impressions * Collecting timeouts data * Collecting resaponses and no_bids data * changed a name function * added event bidRequested * added event bidRequested * added function initialization events * fixed bug * save * added tests * Added processing of the disabledSendingStatisticData parameter, which disables sending statistics data * changed the name of the variables * fixed bug - added required parameter for openrtb request * ZetaGlobalSsp: provide schain (#9678) Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com> Co-authored-by: Alexey Surovenko <ASurovenko@vdhk6ddf9m.home> * Underdog Media Bid Adapter: Switch request to method to POST (#9547) * switch UDM adapter request to post * add siteId to url * add support for 33 across id * Nativo Bid Adapter: adding UserId support (#9583) * Initial nativoBidAdapter document creation (js, md and spec) * Fulling working prebid using nativoBidAdapter. Support for GDPR and CCPA in user syncs. * Added defult size settings based on the largest ad unit. Added response body validation. Added consent to request url qs params. * Changed bidder endpoint url * Changed double quotes to single quotes. * Reverted package-json.lock to remove modifications from PR * Added optional bidder param 'url' so the ad server can force- match an existing placement * Lint fix. Added space after if. * Added new QS param to send various adUnit data to adapter endpopint * Updated unit test for new QS param * Added qs param to keep track of ad unit refreshes * Updated bidMap key default value * Updated refresh increment logic * Refactored spread operator for IE11 support * Updated isBidRequestValid check * Refactored Object.enties to use Object.keys to fix CircleCI testing errors * Updated bid mapping key creation to prioritize ad unit code over placementId * Added filtering by ad, advertiser and campaign. * Merged master * Added more robust bidDataMap with multiple key access * Deduped filer values * Rolled back package.json * Duped upstream/master's package.lock file ... not sure how it got changed in the first place * Small refactor of filterData length check. Removed comparison with 0 since a length value of 0 is already falsy. * Added bid sizes to request * Fixed function name in spec. Added unit tests. * Added priceFloor module support * Added protection agains empty url parameter * Changed ntv_url QS param to use referrer.location instead of referrer.page * Removed testing 'only' flag * Added ntv_url QS param value validation * Added userId support * Added unit tests, refactored for bugs * Wrapped ajax in try/catch * Added more unit testing * Updated eid check for duplicate values. Removed error logging as we no longer need it. * Kulturemedia Bid Adapter: New Adapter (#9613) * Initial implementation of kulturemedia bid adapter * Changing outstream to instream * Enriching md file with test examples * Changing nId to networkId * Cleaning up md file --------- Co-authored-by: Danijel Predarski <danijel.p@whitecitysoft.com> * GDPR consent management: accept static config without `getTCData` (#9664) * Revert "Nativo Bid Adapter: adding UserId support (#9583)" (#9691) This reverts commit aa100bc72df52fe2e6c9bb7bcf41be9867c65be5. * SmartyTech Bid Adapter : add size parameters (#9692) * Add new bid adapter for company smartytech * change domain to prod * update unit tests * remove unused code * remove unused code * add video type * update documentation * Bump tibdex/github-app-token from 1.7.0 to 1.8.0 Bumps [tibdex/github-app-token](https://github.com/tibdex/github-app-token) from 1.7.0 to 1.8.0. - [Release notes](https://github.com/tibdex/github-app-token/releases) - [Commits](https://github.com/tibdex/github-app-token/compare/021a2405c7f990db57f5eae5397423dcc554159c...b62528385c34dbc9f38e5f4225ac829252d1ea92) --- updated-dependencies: - dependency-name: tibdex/github-app-token dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * add ability to force set banner size --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Criteo Bid Adapter: reinforce adomain type in case of missmatch (#9687) * Update criteoBidAdapter.js * Update auction.js * LiveIntent UserId module: update LiveConnect dependency (#9672) * Update LiveConnect dependency * Shorter fire timeout longer wait timeout * Check for liveConnect presence before attempting to fire * Rename defaultEventDelay to fireEventDelay * Clean-up package-lock.json * Do not fire event in userId spec * Remove duplicate function --------- Co-authored-by: Viktor Dreiling <viktor@Viktors-MBP.fritz.box> Co-authored-by: Viktor Dreiling <viktor@Viktors-MacBook-Pro.local> * minutemediaplus Bid Adapter - pass gpp, sua and bid data to server. (#9637) * DistroScale bidder enhancement (#9641) * Disable describe.only and it.only (#9693) * Permutive RTD Module: migrate appnexus to ortb2 (#9630) * fix(permutiveRtd): migrate appnexus to ortb2 keywords * test(permutiveRtd): remove outdated appnexus test * fix(permutiveRtd): remove bidder specific logic for keywords * fix(permutiveRtd): remove alias map in legacy segment setting * Revert "fix(permutiveRtd): remove alias map in legacy segment setting" This reverts commit e1fa6347ad29ba3c14e76fffad46a081d9d6da95. * changed the URL (#9698) * Core: improve FPD enrichment (#9659) * Move sua logic to core * Improve FPD enrichment: merge in `setConfig({app, device, site})`; leave only one of `dooh`, `app`, `site`; enrich the one left with `domain` / `publisher` * ShowHeroes Bid Adapter: added support for USP (#9681) * add ShowHeroes Adapter * ShowHeroes adapter - expanded outstream support * Revert "ShowHeroes adapter - expanded outstream support" This reverts commit bfcdb913b52012b5afbf95a84956b906518a4b51. * ShowHeroes adapter - expanded outstream support * ShowHeroes adapter - fixes (#4222) * ShowHeroes adapter - banner and outstream fixes (#4222) * ShowHeroes adapter - description and outstream changes (#4222) * ShowHeroes adapter - increase test coverage and small fix * ShowHeroes Adapter - naming convention issue * Mixed AdUnits declaration support * ITDEV-4723 PrebidJS adapter support with SupplyChain module object * ITDEV-4723 Fix tests * ITDEV-4723 New entry point * showheroes-bsBidAdapter: Add support for advertiserDomains * showheroes-bsBidAdapter: hotfix for outstream render * showheroes-bsBidAdapter: update renderer url * showheroes-bsBidAdapter: use only the necessary fields from the gdprConsent * ShowHeroes adapter - added a new endpoint * ShowHeroes adapter - unit tests * Update showheroes-bsBidAdapter.md * ShowHeroes adapter - added support for USP --------- Co-authored-by: veranevera <vera.yukhina@showheroes.com> Co-authored-by: Elizaveta Voziyanova <44549195+h2p4x8@users.noreply.github.com> * VIS.X fix onTimeout data (#9657) * Fluct Bid Adapter: add user sync support (#9651) * feat: implementation getUserSyncs for image * user syncs * fix * return all syncs * correct referer -> page * add regs.{gdpr,us_privacy,coppa} to reqs --------- Co-authored-by: Ryo Sakuma <SRkuma@users.noreply.github.com> * Prebid 7.42.0 release * Increment version to 7.43.0-pre * fix lint and test failures * Adagio Bid Adapter : add new params `splitKeyword` and `dl` to bidRequest payload (#9694) * Add splitKeyword and dl params * Update the `dl` to `dataLayer` for user and check the type * Fix code convention, remove the toString on object properties * GumGum Bid Adapter : send gpp data in bidrequest (#9707) * Add GPP support in the bid request * Change parameter name from applicabaleSection to gpp_sid * FPD Enrichment: use low entropy method by default to fetch user agent data (#9711) * Adkernel Bid Adapter: add adlive.io alias (#9714) * Adkernel Bid Adapter: adlive.io alias * Update adkernelBidAdapter.js * Update Permutive RTD documentation (#9697) * added fix and support for multibid module (#9602) Co-authored-by: adish <adish.r@media.net> * Sonobi Bid Adapter: add IntentIq Id (#9649) * Add intentIq Id to trinity request. * Minimized function to needed components. * Added return statemen. * Fixed return statement linter rule. * Changes suggested in PR review. * Added date to trinity request. Updated tests. --------- Co-authored-by: Zac Carlin <zcarlin@C02DP5X4MD6R.local> * Concert Bid Adapter: enable support for GPP consent and remove user sync (#9700) * collect EIDs for bid request * add ad slot positioning to payload * RPO-2012: Update local storage name-spacing for c_uid (#8) * Updates c_uid namespacing to be more specific for concert * fixes unit tests * remove console.log * RPO-2012: Add check for shared id (#9) * Adds check for sharedId * Updates cookie name * remove trailing comma * [RPO-3152] Enable Support for GPP Consent (#12) * Adds gpp consent integration to concert bid adapter * Update tests to check for gpp consent string param * removes user sync endpoint and tests * updates comment * cleans up consentAllowsPpid function * comment fix * rename variables for clarity * fixes conditional logic for consent allows function (#13) --------- Co-authored-by: antoin <antoin.campbell@voxmedia.com> Co-authored-by: Antoin <antoinfive@gmail.com> * CORE: add bid to winningBids when marking as used (#9612) * sets bid.status to rendered * adds winnings bid when marking as used * updates tests * Display.io Bid Adapter: ad request parameters renaming, user session saving (#9553) * Display.io: ad request parameters renaming, user session saving * Display.io Bid Adapter: using StorageManager instead localStorage directly * CORE: allow to disable setting the pbjs global variable (#9568) * allow to disable settings the pbjs global variable * factored out all references to $$PREBID_GLOBAL$$ to use getGlobal instead updated the babel module, to directly call the getGlobal function removed eslint global exception, and added them as local exceptions * fix comments * make module use getGlobal * Isolate `installedModules` management from module namespaces * Use relative import paths in autogenerated code for `installedModules` * Remove $$PREBID_GLOBAL$$ macro ref from rubicon adapter * Revert "Remove $$PREBID_GLOBAL$$ macro ref from rubicon adapter" This reverts commit 16e25ddc536d0b96aae0b13130816812347e0128. --------- Co-authored-by: Demetrio Girardi <dgirardi@prebid.org> * chore: update `getAudiencesAsBidderOrtb2` implementation and test (#9720) * RTBHouse Bid Adapter: change `source.tid` to contain `auctionId` and populate imp-level `ext.tid` (#9726) * RTBHouse Bid Adapter: add global vendor list id * structured user agent - browsers.brands * fix lint errors * Added sda into rtbhouse adapter * spreading ortb2: user & site props * examples reverted * init version * using mergedeep * removed wrong imp array augm.; slot imp augm. with addtl check * [SUA] merging ortb2.device into request * fledge auctionConfig adapted to our bid response structure * new bidder response structure for fledge * make sure bidderRequest has proper flag turned on * fledge endpoint hardcoded; code cleanups * remove obsolete function * obsolete function removed * [RTB House] Process FLEDGE request/response (#4) * [SDA & SUA] refactor using mergedeep * [FLEDGE] fledge auctionConfig adapted to our bid response structure * [FLEDGE] new bidder response structure for fledge * [FLEDGE] make sure bidderRequest has proper flag turned on * [FLEDGE] fledge endpoint hardcoded; code cleanups * [FLEDGE] remove obsolete functions * fixed lint errors * fledge test suites; adapter: delete imp.ext.ae when no fledge (#5) * RTBHouse Bid Adapter: use auctionId for source.tid * RTBHouse bid adapter: fixed source.tid tests * Imp level transaction id + mapSource fix * lint: removed obsolete whitespaces * RTBHouse Bid Adapter: change `source.tid` to contain `auctionId` and populate imp-level `ext.tid` (#8) * RTBHouse Bid Adapter: use auctionId for source.tid * Imp level transaction id + mapSource fix * lint: removed obsolete whitespaces --------- Co-authored-by: Leandro Otani <leandro.otani@rtbhouse.com> Co-authored-by: rtbh-lotani <83652735+rtbh-lotani@users.noreply.github.com> Co-authored-by: Tomasz Swirski <tomasz.swirski@rtbhouse.com> * Adloox AdServer Video : lengthen test timeouts (#9728) * Adloox AdServer Video : lengthen test timeout * Update adlooxAdServerVideo_spec.js * Update adlooxAdServerVideo_spec.js * Update realvuAnalyticsAdapter_spec.js * Update realvuAnalyticsAdapter_spec.js * change to 5500 * change realvu to 3500 * Update adlooxAdServerVideo_spec.js * Smaato: Adapters that accept geolocation data from bid parameters should also accept it from ortb2.(device|user).geo (#9676) (#9725) * Add 9 Dots Media alias (#9699) * Add 9 Dots Media alias * lint * Wrap aliases in quotes in test * Core: allow restriction of cookies / localStorage through `bidderSettings.*.storageAllowed` (#9660) * Core: allow restriction of cookies / localStorage through `bidderSettings.*.storageAllowed` * Add test cases * Prebid 7.43.0 release * Increment version to 7.44.0-pre * IntentIQ Analytics Module : initial release (#9322) * Adding IIQ analytical adapter * IIQ Analytical adapter MD * Test fix * Test fix * Modules Documentation * Test change --------- Co-authored-by: Julian <julian.rassolov@gmail.com> * Revert "IntentIQ Analytics Module : initial release (#9322)" (#9734) This reverts commit 67184b035a46e042cd86049f2b5fec70bfce8cdf. * Taboola Bid Adapter: resolve AUCTION_PRICE macro (#9735) * replace-macro * replace-macro * replace-macro * Prebid Server adapter: fledge support (#9342) * Move fledge logic to fledge module * Change fledge interpretResponse API: from {bidId, ...fledgeAuctionConfig} to {bidId, config: fledgeAuctionConfig} * Fledge ORTB processors * PBS adapter fledge impl * Update modules/fledgeForGpt.js Co-authored-by: Laurentiu Badea <laurb9@users.noreply.github.com> * fix fledge tests to pass adUnitCode * Update text * Fix test case to reflect check on `navigator.joinAdInterestGroup` * Adjust warnings * Name change --------- Co-authored-by: Laurentiu Badea <laurb9@users.noreply.github.com> * remove timeout on synchronous test (#9738) * AdsInteractive Bid Adapter: new bid adapter (#9586) * AdsInteractive adapter first commit * minor changes for the best bidding * add new test params * add meta obj, simplify condition * simplify condition * beutify conditions * add usersync, gdpr, fix interpretResp --------- Co-authored-by: pfeifer.daniel83 <pfeifer.daniel83@gmail.com> * Build system: fix build error on Windows (#9743) * DSPx bid adapter: bidder enhancement (#9674) * Dspx: improve floorprice support, dynamic mediatype handling and shared id support; add video context/renderer support and schain * kick of tests * Dspx: improve floorprice support, dynamic mediatype handling and shared id support; add video context/renderer support and schain --------- Co-authored-by: Alexander <avj83@list.ru> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> * Core: do not allow bidders to run syncs more than once (#9695) * TheMediaGrid: update gpid logic (#9748) * StroeerCore Bid Adapter: handle gdpr applies correctly (#9740) * Dspx Bid Adapter : fix Linting Error (#9750) * BEdigitech Bid Adapter: New Bid Adapter (#9603) * Added bedigital adatper * Added test cases for bedigital adapter * changed email id * Added params in payload as suggestio in review --------- Co-authored-by: yogesh.ingale1 <yogesh.ingale@ai-fluence.com> * bug in AMX bid adapter: assumed filterSettings is not null (#9737) restore package-lock.json * Update secureCreatives.js (#9739) * SharedID: wait for ID from pixel on first page load (#9756) * bugfix in vidoomy adapter: schain serialized (#9759) * Add ext.tid to data when creating slot params (#9745) * 33across Id System: Stop generating error for all cookied users (#9760) * Update 33acrossIdSystem.js * Update 33acrossIdSystem.js * Update 33acrossIdSystem_spec.js * Multiple Adapters : removing cross-module imports (#9617) * Removed 'CreateEidsArray' import statements, as well as references to it within corresponding functions. Added references to 'userIdAsEids' property as an alternative * Revert "Removed 'CreateEidsArray' import statements, as well as references to it within corresponding functions. Added references to 'userIdAsEids' property as an alternative" This reverts commit f654a5b75f70485e98d8e630d6302f258baa7624. * passed all tests * passed tests with bluebillywigAdapter * Impactify bid adapter passed tests * Mediakeys bid adapter passing tests * Sharethrough bid adapter passed tests * Connectad bid adapter passed tests * Added tests back to expectedEids object, and adjusted userIdAsEids array to reflect changes * Yieldmo bid adapter passed tests * Smartadserver bid adapter passed tests * Removed unnecessary reassignment of bidUserId to eids * Removed unnecessary reassignment of bidUserId to eids * Improveddigital bid adapter passed tests * Yieldmo bid adapter passed tests * Sovrn bid adapter passed tests * Ttd bid adapter passed tests * Removed reference to userIdAsEids to ensure tdid property is not undefined * Addressed issue where eids could return null or undefined * Build system: do not allow cross-module imports (#8293) * eslint validate-imports plugin: do not allow cross-module imports * Update onetag * fix conflicts * update imports * refactor audiencerun & jixie --------- Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> Co-authored-by: caseywhitmire <60086994+caseywhitmire@users.noreply.github.com> * Core: cache `rerefererInfo` as long as location does not change (#9670) * Greenbids Analytics Adapter: create new analytics adapter for Greenbids (#9690) * Add Greenbids Analytics module * fix doc * rework payload * LocalStorage availability logging (#9755) * Craft Bid Adapter : update for imuIdSystem (#9757) * update craftBidAdapter for imuIdSystem * update craftBidAdapter for develop * ZetaGlobalSsp Bid Adapter: provide tagid from params (#9764) * ZetaGlobalSsp: provide tagid from params * fix test --------- Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com> Co-authored-by: Alexey Surovenko <ASurovenko@vdhk6ddf9m.home> * AIDEM Bid Adapter: extended app/site parameters on win notice (#9765) * AIDEM Bid Adapter * Added _spec.js * update * Fix Navigator in _spec.js * Removed timeout handler. * Added publisherId as required bidder params * moved publisherId into site publisher object * Added wpar to environment * Added placementId parameter * added unit tests for the wpar environment object * PlacementId is now a required parameter Added optional rateLimit parameter Added publisherId, siteId, placementId in win notice payload Added unit tests * Revert to optional placementId parameter Added missing semicolons * Extended win notice --------- Co-authored-by: Giovanni Sollazzo <gs@aidem.com> Co-authored-by: darkstar <canazza@wazabit.it> * BrightcomSSP, Brightcom: remove options overide from buildRequests (#9753) * TTD Bid Adapter: add support for video.plcmt and imp.rwdd (#9762) * Update ttdBidAdapter.js * Update ttdBidAdapter_spec.js * Update ttdBidAdapter_spec.js * Update ttdBidAdapter_spec.js * Update ttdBidAdapter_spec.js * Update ttdBidAdapter.js * Update ttdBidAdapter_spec.js * Criteo ID Module: Add error callback for pixel sync call (#9754) Co-authored-by: v.raybaud <v.raybaud@criteo.com> * PubMatic Bid Adapter: native 1.2 support (#9701) * Changes for native 1.2 support * Bug fixes and testacases updation * Changes to include ext and mimes properties of assets and added condition to read len OR length param value * Bug fixes * Bug fix and test cases fix * Test * Test * Update undertoneBidAdapter.js (#9778) * appnexus bid adapter - add gvlids to aliases (#9777) * Update gumgumBidAdapter.js (#9779) * Multiple modules: decouple GVL IDs from storage access control (#9736) * Core: allow restriction of cookies / localStorage through `bidderSettings.*.storageAllowed` * Add test cases * Remove gvlid param from storage manager logic * Refactor every invocation of `getStorageManager` * GVL ID registry * Refactor gdprEnforcement gvlid lookup * fix lint * Remove empty file * Undo https://github.com/prebid/Prebid.js/pull/9728 for realVu * Fix typo * Multiple bids in one request to Adrino Adserver (#9742) Co-authored-by: Tomasz Mielcarz <tomasz.mielcarz@adrino.pl> * size map support (#9772) * OpenxOrtbAdapter: add back missing params support for coppa and video (#9782) * Criteo Bid Adapter: Read GPP from ortb2 object (#9775) Add support of GPP consent string when it is present in ortb2 object. * vidazoo Bid Adapter: update support of metaData (#9749) * feat(module): multi size request * fix getUserSyncs added tests * update(module): package-lock.json from master * feat(module): VidazooBidAdapter - send top query params to server * feat: support metaData from server response. * remove forgotten only on spec. --------- Co-authored-by: Udi Talias <udi.talias@gmail.com> Co-authored-by: roman <shmoop207@gmail.com> * Concert Bid Adapter: Enable support for additional userId's (#9780) * collect EIDs for bid request * add ad slot positioning to payload * RPO-2012: Update local storage name-spacing for c_uid (#8) * Updates c_uid namespacing to be more specific for concert * fixes unit tests * remove console.log * RPO-2012: Add check for shared id (#9) * Adds check for sharedId * Updates cookie name * remove trailing comma * [RPO-3152] Enable Support for GPP Consent (#12) * Adds gpp consent integration to concert bid adapter * Update tests to check for gpp consent string param * removes user sync endpoint and tests * updates comment * cleans up consentAllowsPpid function * comment fix * rename variables for clarity * fixes conditional logic for consent allows function (#13) * [RPO-3262] Update getUid function to check for pubcid and sharedid (#14) * Update getUid function to check for pubcid and sharedid * updates adapter version --------- Co-authored-by: antoin <antoin.campbell@voxmedia.com> Co-authored-by: Antoin <antoinfive@gmail.com> * Prebid 7.44.0 release * Increment version to 7.45.0-pre * vidoomy adapter: added bidfloor module (#9784) * Prebid core: fix image assets in converted legacy response (#9752) * Mgid Adapter: update & refactor (#9751) * upd - better support ortb2 - implement getUserSyncs - some refactoring * upd - better support ortb2 - implement getUserSyncs - some refactoring * upd * fix eids import --------- Co-authored-by: gaudeamus <dmitry.markelov@mgid.com> * Various Bid Adapters: point tmax at request object (#9770) * Removed 'CreateEidsArray' import statements, as well as references to it within corresponding functions. Added references to 'userIdAsEids' property as an alternative * Revert "Removed 'CreateEidsArray' import statements, as well as references to it within corresponding functions. Added references to 'userIdAsEids' property as an alternative" This reverts commit f654a5b75f70485e98d8e630d6302f258baa7624. * passed all tests * passed tests with bluebillywigAdapter * Impactify bid adapter passed tests * Mediakeys bid adapter passing tests * Sharethrough bid adapter passed tests * Connectad bid adapter passed tests * Added tests back to expectedEids object, and adjusted userIdAsEids array to reflect changes * Yieldmo bid adapter passed tests * Smartadserver bid adapter passed tests * Removed unnecessary reassignment of bidUserId to eids * Removed unnecessary reassignment of bidUserId to eids * Improveddigital bid adapter passed tests * Yieldmo bid adapter passed tests * Sovrn bid adapter passed tests * Ttd bid adapter passed tests * Refactored adapters to draw tmax values from bidderRequest object and ensured they were passing tests * Update nexx360BidAdapter.js * Deleted unrelated ttsBidAdapter file from PR * Deleted unrelated ttdBidAdapter_spec file from PR * add back ttd adapter * add ttd spec flle back * add new line --------- Co-authored-by: Patrick McCann <pmccann@cafemedia.com> Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> * OpenXOrtb Bid Adapter: fix multiformat requests (#9790) * OpenXOrtb: fix multiformat requests * pay attention to feature tags * refactor & cleanup * FreeWheel SSP Bid Adapter: support video context and placement (#9792) * FreeWheel add floor price * FreeWheel code update * FreeWheel-SSP-Adapter: Update to use Vast 4.2 by default * FreeWheel-SSP-Adapter add userIdAsEids support * Freewheel-SSP-Adapter add test for eids * Freewheel SSP Adapter: add prebid version in request * code cleanup * FreeWheel SSP Bid Adapter: support video context and placement * update test * IX Bid Adapter: refactor build request method and ft improves (#9793) Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> * AMX ID System: allow cookie storage (#9761) * Update AMXIdSystem logic, allow non-html5 storage, refactor sharedId domainOverride function into library * Fix failing test, bad invocation of getStorageManager * Yahoo ConnectId UserID Module: explicit storage management (#9716) * Explicitly manage storage of ConnectID * Addressed initial PR feedback * Documentation update * Address consent logic issues * Prevent storage of empty object response from UPS * Change storage key to match module name. --------- Co-authored-by: slimkrazy <sam@slimkrazy.com> * Ogury Adapter add device density in bid request (#9796) * Growthcode UserId: Bug fixes & Better Error Catching (#9785) * Remove the cookie storage for data. * Clean up error checking on return JSON data. * Code cleanup * LiveIntent UserId module: Add support for bidswitch and medianet ids (#9703) * Add support for bidswitch id * Add test * Update liveIntentIdSystem_spec.js * Fix test * Add medianet cookie * Change atype from 508 to 3 * Revert version change in package-lock.json * Add bidswitch.com and media.net examples * Customer request: change bidswitch.com to bidswitch.net --------- Co-authored-by: Viktor Dreiling <viktor@Viktors-MBP.fritz.box> Co-authored-by: Viktor Dreiling <viktor@Viktors-MacBook-Pro.local> * Yahoo ConnectId UserID Module: Resolving getStorageManager invocation issue (#9798) * Resolving getStorageManager invocation issue * Lint * MODULE_TYPE -> moduleType * CORE: disable the requirement for having a url, when enabling renderNow in Renderer (#9769) * disable the requirement for having a url, when enabling renderNow in the Renderer * kick off circleci --------- Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com> * JW Player Video Adapter: Support multiple setup listeners (#9791) * supports multiple setup listeners * adds length check * Pub-X Bid Adapter: adding page url support (#9746) * Pub-X Bid Adapter: adding page url support * Refactored to use site.page * Update pubxBidAdapter.js getting circleci to run --------- Co-authored-by: Patrick McCann <pmccann@cafemedia.com> * Magnite Analytics Adapter : add seat non bid handling (#9696) * Return all bids * Adjust findMatch function * Return all buds unit testing * Responds to review comments * Unit test adjustments * Remove extra line for lint * minor changes * doh --------- Co-authored-by: Robert Ray Martinez III <rrmartinez1552@gmail.com> * openxBidAdapter: update to OpenRTB adapter (#9794) * openxBidAdapter: update to OpenRTB adapter * remove skipped tests * IVS Bid Adapter: initial adapter release (#9706) * Add IVS bid adapter * Fix publisherId in test parameters * IVS bid adapter: fix tests (#9807) * Prebid 7.45.0 release * Increment version to 7.46.0-pre * Criteo Bid Adapter: Fix invalid deal property name mapping from bidder response (#9808) Currently, our PBJS adapter code expects to receive a property called 'dealCode' where our bidder emits 'deal' instead. We've updated our backend to temporary emit both dealCode & deal but long term we'd like to align to use 'deal 'across all integrations. * Kargo Bid Adapter: Refactor of bid request (#9731) * pageURL pull from topmostLocation * Kargo: Support for client hints (#9) * Starting SUA support * Kargo: Adding support for client hints * Adding tests for sua * Kargo: Update referer logic * Refactor of Kargo Prebid adapter. * PR comments addressed. * Feedback addressed. * Pr comments addressed. * Continuing refactor of Kargo Bid adapter. * Logic adjustment to exclude values when not present. Relying on server defaults. * Updating unit tests. * PR feedback addressed. * Refactoring bid adapter functions. * PR feedback addressed. * Additional refactoring. * Refactoring for each to use Object entries. * Minor fixes. * Minor fixes. * Minor fixes. * TDID and linting updates * Conflicts resolved with master. * Re-adding raw CRB storage (#14) * Updating shared IDs object name * Fixing missing ad markup * Removing package json changes. Fixing unit tests broken by recent changes. * Linting * send requestCount even when it is 0 for BTO (#18) * Reverting package.json change * Reverting package-lock.json changes * Cleanup * Test cleanup * Test fix Test fix All tests fixed * Adding test for TDID * Resolving merge issue --------- Co-authored-by: Neil Flynn <nflynn@kargo.com> Co-authored-by: Julian Gan <juliangan07@gmail.com> * Criteo Bid Adapter: Map device sua field to user ext sua (#9809) Co-authored-by: v.raybaud <v.raybaud@criteo.com> * Deleted the global.site.cattax field as it is not defined in openrtb 2.5 (#9810) * kueezRtb Bid Adapter: Add support for passing metaData object from server response. (#9815) * AdMatic Bid Adapter: badv added (#9820) * Admatic Bidder Adaptor * Update admaticBidAdapter.md * Update admaticBidAdapter.md * remove floor parameter * Update admaticBidAdapter.js * Admatic Bid Adapter: alias and bid floor features activated * Admatic adapter: host param control changed * Alias name changed. * Revert "Admatic adapter: host param control changed" This reverts commit de7ac85981b1ba3ad8c5d1dc95c5dadbdf5b9895. * added alias feature and host param * Revert "added alias feature and host param" This reverts commit 6ec8f4539ea6be403a0d7e08dad5c7a5228f28a1. * Revert "Alias name changed." This reverts commit 661c54f9b2397e8f25c257144d73161e13466281. * Revert "Admatic Bid Adapter: alias and bid floor features activated" This reverts commit 7a2e0e29c49e2f876b68aafe886b336fe2fe6fcb. * Revert "Update admaticBidAdapter.js" This reverts commit 7a845b7151bbb08addfb58ea9bd5b44167cc8a4e. * Revert "remove floor parameter" This reverts commit 7a23b055ccd4ea23d23e73248e82b21bc6f69d90. * Admatic adapter: host param control && Add new Bidder * Revert "Admatic adapter: host param control && Add new Bidder" This reverts commit 3c797b120c8e0fe2b851381300ac5c4b1f92c6e2. * commit new features * Update admaticBidAdapter.js * updated for coverage * sync updated * Update adloader.js * AdMatic Bidder: development of user sync url * Update admaticBidAdapter.js * Set currency for AdserverCurrency: bug fix * Update admaticBidAdapter.js * update * MinuteMediaPlus Bid Adapter: Add support for passing metaData object from server response. (#9816) * Nativo Bid Adapter: Adding UserId support (#9767) * Initial nativoBidAdapter document creation (js, md and spec) * Fulling working prebid using nativoBidAdapter. Support for GDPR and CCPA in user syncs. * Added defult size settings based on the largest ad unit. Added response body validation. Added consent to request url qs params. * Changed bidder endpoint url * Changed double quotes to single quotes. * Reverted package-json.lock to remove modifications from PR * Added optional bidder param 'url' so the ad server can force- match an existing placement * Lint fix. Added space after if. * Added new QS param to send various adUnit data to adapter endpopint * Updated unit test for new QS param * Added qs param to keep track of ad unit refreshes * Updated bidMap key default value * Updated refresh increment logic * Refactored spread operator for IE11 support * Updated isBidRequestValid check * Refactored Object.enties to use Object.keys to fix CircleCI testing errors * Updated bid mapping key creation to prioritize ad unit code over placementId * Added filtering by ad, advertiser and campaign. * Merged master * Added more robust bidDataMap with multiple key access * Deduped filer values * Rolled back package.json * Duped upstream/master's package.lock file ... not sure how it got changed in the first place * Small refactor of filterData length check. Removed comparison with 0 since a length value of 0 is already falsy. * Added bid sizes to request * Fixed function name in spec. Added unit tests. * Added priceFloor module support * Added protection agains empty url parameter * Changed ntv_url QS param to use referrer.location instead of referrer.page * Removed testing 'only' flag * Added ntv_url QS param value validation * Added userId support * Added unit tests, refactored for bugs * Wrapped ajax in try/catch * Added more unit testing * Updated eid check for duplicate values. Removed error logging as we no longer need it. * Removed spec test .only. Fixed unit tests that were breaking. * Added Prebid version to nativo exchange request * Removed unused bidder methods * vidoomy adapter: added userid module (#9795) * KargoBidAdapter: GPP Support (#9812) * support VIDEO feature flag in PubMatic bid adapter (#9744) * Eskimi Bid Adapter: initial adapter release (#9768) * rewrite the adapter to use ortbConverter * Eskimi: fix `isBidRequestValid` * Eskimi: fix request validation tests --------- Co-authored-by: Sekandar <sekandar@eskimi.com> * Update the Conversant adapter to have source.tid to have auctionId (#9822) Co-authored-by: johwier <john.wier@epsilon.com> * MinuteMediaPlus Bid Adapter: Pass gpid to server. (#9830) * IX Bid Adapter: Support for Ad unit specific First Party Data (#9821) * feat: add adunit specific fpd support [PB-1387] * feat: move duplicate code to its function [PB-1387] --------- Co-authored-by: shahin.rahbariasl <shahin.rahbariasl@indexexchange.com> * KueezRtb Bid Adapter: Pass gpid to server. (#9831) * Adnuntius Bid Adapter: Europe endpoint (#9829) * Adnuntius Bid Adapter: Route traffic to euro-servers if GDPR applies. * Tests Added to gdpr applies. * TheMediaGrid: make gridNMBidAdater as alias for gridBidAdapter (#9832) * TheMediaGrid: make gridNMBidAdater as alias for gridBidAdapter * TheMediaGrid: fix alias name * pairId userId submodule: initial commit for pairId submodule (#9662) * add userId submodule for pairId system * [PairIdSystem] add logic to fetch from liveramp cookie * Fix liveramp local storage/cookie key for PairId * addressed PR review comments * Build Process: Disallow it.skip (#9799) * Update realvuAnalyticsAdapter_spec.js * Update axonixBidAdapter_spec.js * Update pubCommonId_spec.js * Update test_index.js * Update test_index.js * Update adagioBidAdapter_spec.js * Update test_index.js * Update test_index.js * Update test_index.js * Update test_index.js * Update openxOrtbBidAdapter_spec.js * Update 1plusXRtdProvider_spec.js * Update pubmaticBidAdapter_spec.js * Pair ID system: fix storageManager invocation (#9833) * Yieldmo Adapter: Send GPP data in bid request. (#9460) * Adding gpp and gpp_sid adding gpp parameters to Banner and Video bids. * Sending gdpr data if no gpp * Refactor * Bidwatch Analytics Adapter: add of the referer for bid won (#9818) * Mediasquare Bid Adapter: add of the referer for onBidWon (#9817) * Mediasquare Bid Adapter: add of the referer for onBidWon * Mediasquare Bid Adapter: replay test * vidoomy adapter: sync url changed (#9834) * Support VIDEO feature flag in AppNexus bid adapter (#9653) * ortbConverter: support video.plcmt (#9840) * Documentation: Add FLEDGE aka Protected Audience API examples (#9839) * Add FLEDGE aka Protected Audience API examples * Remove alias from pbs example * Core: fix spurious warnings on `mergeConfig` (#9704) * Core: fix spurious warnings on `mergeConfig` * Fix sendAllBid config name * Prebid 7.46.0 release * Increment version to 7.47.0-pre * vidoomy adapter: added block module (#9825) * Sending empty array instead of string. (#9846) * RTB house Bid Adapter: fix encoding bug for bid response for native ads (#9850) * RTB hose Bid Adapter: encode URI corecctly using encodeURI instead of encodeURIComponent * Missena Bid Adapter: fix alias (#9849) * add EMTV adapter (#9783) * Criteo Id Module: ensure all kind of privacy strings are sent to backend (#9845) Also adding missing gdpr applies flag * NextMillennium Bd Adapter : add gvlid (#9858) * add gvlid * no change * Prebid 7.47.0 release * Increment version to 7.48.0-pre * Adrino Bid Adapter: banner support added (#9860) * banner support added * test name change * not my test failed * not my test failed --------- Co-authored-by: Tomasz Mielcarz <tomasz.mielcarz@adrino.pl> * Criteo Bid Adapter: Map native assets to slot.ext.assets (#9851) Co-authored-by: v.raybaud <v.raybaud@criteo.com> * Realvu analytics adapter: fix test failures on Edge (#9857) * Realvu analytics adapter: fix test failures on Edge * Remove realVu tests * ORTB2 bcat & badv support + ORTB2 tests (#9871) * AdMatic Bid Adapter: added Video / Banner params (#9856) * Admatic Bidder Adaptor * Update admaticBidAdapter.md * Update admaticBidAdapter.md * remove floor parameter * Update admaticBidAdapter.js * Admatic Bid Adapter: alias and bid floor features activated * Admatic adapter: host param control changed * Alias name changed. * Revert "Admatic adapter: host param control changed" This reverts commit de7ac85981b1ba3ad8c5d1dc95c5dadbdf5b9895. * added alias feature and host param * Revert "added alias feature and host param" This reverts commit 6ec8f4539ea6be403a0d7e08dad5c7a5228f28a1. * Revert "Alias name changed." This reverts commit 661c54f9b2397e8f25c257144d73161e13466281. * Revert "Admatic Bid Adapter: alias and bid floor features activated" This reverts commit 7a2e0e29c49e2f876b68aafe886b336fe2fe6fcb. * Revert "Update admaticBidAdapter.js" This reverts commit 7a845b7151bbb08addfb58ea9bd5b44167cc8a4e. * Revert "remove floor parameter" This reverts commit 7a23b055ccd4ea23d23e73248e82b21bc6f69d90. * Admatic adapter: host param control && Add new Bidder * Revert "Admatic adapter: host param control && Add new Bidder" This reverts commit 3c797b120c8e0fe2b851381300ac5c4b1f92c6e2. * commit new features * Update admaticBidAdapter.js * updated for coverage * sync updated * Update adloader.js * AdMatic Bidder: development of user sync url * Update admaticBidAdapter.js * Set currency for AdserverCurrency: bug fix * Update admaticBidAdapter.js * update * admatic adapter video params update * Update admaticBidAdapter.js * update * Update admaticBidAdapter.js * update * update * Update admaticBidAdapter_spec.js * Update admaticBidAdapter.js * Update admaticBidAdapter.js * Revert "Update admaticBidAdapter.js" This reverts commit 1216892fe55e5ab24dda8e045ea007ee6bb40ff8. * Revert "Update admaticBidAdapter.js" This reverts commit b1929ece33bb4040a3bcd6b9332b50335356829c. * Revert "Update admaticBidAdapter_spec.js" This reverts commit 1ca659798b0c9b912634b1673e15e54e547b81e7. * Revert "update" This reverts commit 689ce9d21e08c27be49adb35c5fd5205aef5c35c. * Revert "update" This reverts commit f381a453f9389bebd58dcfa719e9ec17f939f338. * Revert "Update admaticBidAdapter.js" This reverts commit 38fd7abec701d8a4750f9e95eaeb40fb67e9f0e6. * Revert "update" This reverts commit a5316e74b612a5b2cd16cf42586334321fc87770. * Revert "Update admaticBidAdapter.js" This reverts commit 60a28cae302b711366dab0bff9f49b11862fb8ee. * Revert "admatic adapter video params update" This reverts commit 31e69e88fd9355e143f736754ac2e47fe49b65b6. * update * Triplelift Bid Adapter: copying ad unit impression data (#9865) * TL-35335: Cast playbackmethod as array * TL-36204: Copy tid to imp extension obj * Added support for entire ortb2Imp obj * Only setting what exists in ortb2Imp.ext * Added additional test to check copy of entire ext obj * Revert "TL-36204: Copy tid to imp extension object" * TL-36204: Copying ortb2Imp.ext to impression ext obj * Added edge case logic and additional test * recos for tid change * Added spread operator to replace deepClone --------- Co-authored-by: nllerandi3lift <75995508+nllerandi3lift@users.noreply.github.com> Co-authored-by: Nick Llerandi <nllerandi@triplelift.com> * Multiple modules: do not use bidderTimeout as TTL (#9880) * Multiple modules: do not use bidderTimeout as TTL * Fix lint * Grid Bid Adapter: add support for video.plcmt (#9763) * Update gridBidAdapter.js * Update gridBidAdapter_spec.js * Revert "Grid Bid Adapter: add support for video.plcmt (#9763)" (#9882) This reverts commit 2edd264082b2baf0511def2b1fb5c326bad3b3cf. * UPDATE setOrtb user ids to avoid passing an empty array when no user ids present (#9875) Co-authored-by: Alejandro Villanueva <alejandro.villanueva@freestar.io> * Sovrn Bid Adapter: add gpp support (#9811) * feat: update Sovrn bid adapter to send gpp * style: eslint --------- Co-authored-by: feat: add video request fields <> * Triplelift Bid Adapter: relax check on consentString before appending gdprApplies to usersyncs (#9885) * TL-35335: Cast playbackmethod as array * TL-36204: Copy tid to imp extension obj * Added support for entire ortb2Imp obj * Only setting what exists in ortb2Imp.ext * Added additional test to check copy of entire ext obj * Revert "TL-36204: Copy tid to imp extension object" * TL-36204: Copying ortb2Imp.ext to impression ext obj * Added edge case logic and additional test * recos for tid change * Added spread operator to replace deepClone * addresses gdprApplies --------- Co-authored-by: Patrick Loughrey <ploughrey@triplelift.com> * Yahoo connect id storage fixes. (#9854) Co-authored-by: dumitrubarbos <dumitru-radu.barbos@yahooinc.com> * Remove syncstore from adapter (#9890) Co-authored-by: Thomas De Stefano <thomas.destefano@impactify.io> * Adloox server video: mock out blob URLs in tests (#9881) * Relevant Digital Bid Adapter: initial release (#9685) * Relevant Digital Bid Adapter * More tests + comments * Use the recommended onBidWon callback + live-placements in .md file * Remove unused imports + adjust example-parameters in .md file * Renamed files + rewritten test-cases * Added documentation for 'pbsBufferMs' setting * Added 'useSourceBidderCode' setting to use S2S bidder's code instead of the client-side code in responses * Greenbids RTD provider (#9848) * Bump engine.io and socket.io (#9903) Bumps [engine.io](https://github.com/socketio/engine.io) and [socket.io](https://github.com/socketio/socket.io). These dependencies needed to be updated together. Updates `engine.io` from 6.2.1 to 6.4.2 - [Release notes](https://github.com/socketio/engine.io/releases) - [Changelog](htt…

AntonioGargaro changed the title ~~Permutive/migrate appnexus to ortb2~~ Permutive RTD Module: migrate appnexus to ortb2 Mar 7, 2023

AntonioGargaro force-pushed the permutive/migrate-appnexus-to-ortb2 branch from 4ce6d2d to 43d91e8 Compare March 8, 2023 16:20

AntonioGargaro added 2 commits March 8, 2023 17:26

fix(permutiveRtd): migrate appnexus to ortb2 keywords

f4a2062

test(permutiveRtd): remove outdated appnexus test

77eb7ed

AntonioGargaro force-pushed the permutive/migrate-appnexus-to-ortb2 branch from 43d91e8 to 2dc47fb Compare March 8, 2023 17:27

AntonioGargaro marked this pull request as ready for review March 8, 2023 17:31

fix(permutiveRtd): remove bidder specific logic for keywords

4adff93

AntonioGargaro force-pushed the permutive/migrate-appnexus-to-ortb2 branch from 2dc47fb to 4adff93 Compare March 8, 2023 17:47

patmmccann reviewed Mar 8, 2023

View reviewed changes

fix(permutiveRtd): remove alias map in legacy segment setting

e1fa634

AntonioGargaro requested a review from patmmccann March 9, 2023 09:25

Revert "fix(permutiveRtd): remove alias map in legacy segment setting"

3b1c39b

This reverts commit e1fa634.

ChrisHuie assigned patmmccann Mar 9, 2023

ChrisHuie added the feature label Mar 9, 2023

ChrisHuie approved these changes Mar 22, 2023

View reviewed changes

ChrisHuie merged commit a144f5a into prebid:master Mar 22, 2023

AntonioGargaro deleted the permutive/migrate-appnexus-to-ortb2 branch June 27, 2023 09:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Permutive RTD Module: migrate appnexus to ortb2 #9630

Permutive RTD Module: migrate appnexus to ortb2 #9630

AntonioGargaro commented Mar 7, 2023 •

edited

Loading

patmmccann Mar 8, 2023

AntonioGargaro Mar 9, 2023 •

edited

Loading

Permutive RTD Module: migrate appnexus to ortb2 #9630

Permutive RTD Module: migrate appnexus to ortb2 #9630

Conversation

AntonioGargaro commented Mar 7, 2023 • edited Loading

Type of change

Description of change

Other information

patmmccann Mar 8, 2023

Choose a reason for hiding this comment

AntonioGargaro Mar 9, 2023 • edited Loading

Choose a reason for hiding this comment

AntonioGargaro commented Mar 7, 2023 •

edited

Loading

AntonioGargaro Mar 9, 2023 •

edited

Loading