Support Video for GetIntent adapter #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like build failure was caused by Mantis adapter, not ours. |
matthewlane
reviewed
Feb 18, 2017
| bid.width = size[0]; | ||
| bid.height = size[1]; | ||
| if (br.mediaType === 'video') { | ||
| bid.vastUrl = bidResponse.vast_url; |
There was a problem hiding this comment.
You can also set bid.descriptionUrl = bidResponse.vast_url; if you'd like. bid.descriptionUrl is used in pbjs.buildMasterVideoTagFromAdserverTag. This isn't a requirement though, just commenting in case you didn't know about it
bid.descriptionUrl = bidResponse.vast_url;
matthewlane
approved these changes
Feb 21, 2017
Walexander
pushed a commit
to MbidIO/Prebid.js
that referenced
this pull request
Mar 6, 2017
* Update getintent.js * Update getintent_spec.js * Update getintent.js * Update getintent.js * Update getintent_spec.js * fix test * added to list of video adapters * fixy with closures. * jshint fixes * Update getintent.js fixy * Update getintent.js bid.descriptionUrl = bidResponse.vast_url;
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
May 19, 2017
…18.0 to aolgithub-master * commit '2881f03dd76bfcf484fbfeaf0f9e1000b383d20d': Added adapters in aolPartnersIds.json. Added changelog entry. Prebid 0.20.0 Release Remove test that intermittently fails unit tests (prebid#1020) Create bids for requests without mutating ad units (prebid#1019) Use optimize js to improve parse time (https://github.com/nolanlawson/optimize-js) (prebid#1018) Fixes for Centro adapter (prebid#992) adbund adapter (prebid#932) Fix bug with supporting non-cpm dealId bids. (prebid#1006) Added referrer parameter (prebid#966) Support Video for GetIntent adapter (prebid#987) Currency support for SmartAdServer adapter (prebid#979) Deal support for SmartAdServer adapter (prebid#978) Skip test causing build failures (prebid#997) E2etest concurrency (prebid#982) Add ThoughtLeadr adapter (prebid#894) Increment Pre Version
vzhukovsky
added a commit
to aol/Prebid.js
that referenced
this pull request
May 22, 2017
…18.0 to master * commit '2881f03dd76bfcf484fbfeaf0f9e1000b383d20d': Added adapters in aolPartnersIds.json. Added changelog entry. Prebid 0.20.0 Release Remove test that intermittently fails unit tests (prebid#1020) Create bids for requests without mutating ad units (prebid#1019) Use optimize js to improve parse time (https://github.com/nolanlawson/optimize-js) (prebid#1018) Fixes for Centro adapter (prebid#992) adbund adapter (prebid#932) Fix bug with supporting non-cpm dealId bids. (prebid#1006) Added referrer parameter (prebid#966) Support Video for GetIntent adapter (prebid#987) Currency support for SmartAdServer adapter (prebid#979) Deal support for SmartAdServer adapter (prebid#978) Skip test causing build failures (prebid#997) E2etest concurrency (prebid#982) Add ThoughtLeadr adapter (prebid#894) Increment Pre Version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Support Video for GetIntent adapter
Contact