Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple modules: do not use bidderTimeout as TTL #9880

Merged
merged 2 commits into from
May 1, 2023
Merged

Multiple modules: do not use bidderTimeout as TTL #9880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61c21d7
Multiple modules: do not use bidderTimeout as TTL
dgirardi May 1, 2023
b51b584
Fix lint
dgirardi May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions modules/ablidaBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { triggerPixel } from '../src/utils.js';
import {config} from '../src/config.js';
import {triggerPixel} from '../src/utils.js';
import {registerBidder} from '../src/adapters/bidderFactory.js';
import { BANNER, NATIVE, VIDEO } from '../src/mediaTypes.js';
import { convertOrtbRequestToProprietaryNative } from '../src/native.js';
import {BANNER, NATIVE, VIDEO} from '../src/mediaTypes.js';
import {convertOrtbRequestToProprietaryNative} from '../src/native.js';

const BIDDER_CODE = 'ablida';
const ENDPOINT_URL = 'https://bidder.ablida.net/prebid';
Expand Down Expand Up @@ -77,7 +76,7 @@ export const spec = {
const response = serverResponse.body;

response.forEach(function(bid) {
bid.ttl = config.getConfig('_bidderTimeout');
bid.ttl = 60
bidResponses.push(bid);
});
return bidResponses;
Expand Down
12 changes: 6 additions & 6 deletions modules/axonixBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { isArray, logError, deepAccess, isEmpty, triggerPixel, replaceAuctionPrice } from '../src/utils.js';
import { registerBidder } from '../src/adapters/bidderFactory.js';
import { BANNER, VIDEO } from '../src/mediaTypes.js';
import { config } from '../src/config.js';
import { ajax } from '../src/ajax.js';
import {deepAccess, isArray, isEmpty, logError, replaceAuctionPrice, triggerPixel} from '../src/utils.js';
import {registerBidder} from '../src/adapters/bidderFactory.js';
import {BANNER, VIDEO} from '../src/mediaTypes.js';
import {config} from '../src/config.js';
import {ajax} from '../src/ajax.js';

const BIDDER_CODE = 'axonix';
const BIDDER_VERSION = '1.0.2';
Expand Down Expand Up @@ -150,7 +150,7 @@ export const spec = {
for (const resp of response) {
if (resp.requestId) {
responses.push(Object.assign(resp, {
ttl: config.getConfig('_bidderTimeout')
ttl: 60
}));
}
}
Expand Down
5 changes: 2 additions & 3 deletions modules/dspxBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import {deepAccess, getBidIdParameter, logError, logMessage, logWarn, isFn} from '../src/utils.js';
import {config} from '../src/config.js';
import {deepAccess, getBidIdParameter, isFn, logError, logMessage, logWarn} from '../src/utils.js';
import {registerBidder} from '../src/adapters/bidderFactory.js';
import {BANNER, VIDEO} from '../src/mediaTypes.js';
import {Renderer} from '../src/Renderer.js';
Expand Down Expand Up @@ -183,7 +182,7 @@ export const spec = {
currency: currency,
netRevenue: netRevenue,
type: response.type,
ttl: config.getConfig('_bidderTimeout'),
ttl: 60,
meta: {
advertiserDomains: response.adomain || []
}
Expand Down
3 changes: 1 addition & 2 deletions modules/iqmBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import {_each, deepAccess, getBidIdParameter, isArray} from '../src/utils.js';
import {registerBidder} from '../src/adapters/bidderFactory.js';
import {config} from '../src/config.js';
import {BANNER, VIDEO} from '../src/mediaTypes.js';
import {INSTREAM} from '../src/video.js';

Expand Down Expand Up @@ -155,7 +154,7 @@ export const spec = {
auctionId: bidRequest.data.auctionId,
mediaType: bidRequest.data.imp.mediatype,

ttl: bid.ttl || config.getConfig('_bidderTimeout')
ttl: bid.ttl || 60
};

if (bidRequest.data.imp.mediatype === VIDEO) {
Expand Down
3 changes: 1 addition & 2 deletions modules/orbitsoftBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import * as utils from '../src/utils.js';
import {registerBidder} from '../src/adapters/bidderFactory.js';
import {config} from '../src/config.js';

const BIDDER_CODE = 'orbitsoft';
let styleParamsMap = {
Expand Down Expand Up @@ -122,7 +121,7 @@ export const spec = {
const HEIGHT = serverBody.height;
const CREATIVE = serverBody.content_url;
const CALLBACK_UID = serverBody.callback_uid;
const TIME_TO_LIVE = config.getConfig('_bidderTimeout');
const TIME_TO_LIVE = 60;
const REFERER = utils.getWindowTop();
let bidRequest = request.bidRequest;
if (CPM > 0 && WIDTH > 0 && HEIGHT > 0) {
Expand Down
7 changes: 3 additions & 4 deletions modules/radsBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { deepAccess } from '../src/utils.js';
import {config} from '../src/config.js';
import {deepAccess} from '../src/utils.js';
import {registerBidder} from '../src/adapters/bidderFactory.js';
import { BANNER, VIDEO } from '../src/mediaTypes.js';
import {BANNER, VIDEO} from '../src/mediaTypes.js';

const BIDDER_CODE = 'rads';
const ENDPOINT_URL = 'https://rads.recognified.net/md.request.php';
Expand Down Expand Up @@ -86,7 +85,7 @@ export const spec = {
dealId: dealId,
currency: currency,
netRevenue: netRevenue,
ttl: config.getConfig('_bidderTimeout'),
ttl: 60,
meta: {
advertiserDomains: response.adomain || []
}
Expand Down
9 changes: 4 additions & 5 deletions modules/stvBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { deepAccess } from '../src/utils.js';
import { config } from '../src/config.js';
import { registerBidder } from '../src/adapters/bidderFactory.js';
import { BANNER, VIDEO } from '../src/mediaTypes.js';
import {deepAccess} from '../src/utils.js';
import {registerBidder} from '../src/adapters/bidderFactory.js';
import {BANNER, VIDEO} from '../src/mediaTypes.js';
import {includes} from '../src/polyfill.js';

const BIDDER_CODE = 'stv';
Expand Down Expand Up @@ -128,7 +127,7 @@ export const spec = {
dealId: dealId,
currency: currency,
netRevenue: netRevenue,
ttl: config.getConfig('_bidderTimeout'),
ttl: 60,
meta: {
advertiserDomains: response.adomain || []
}
Expand Down
21 changes: 9 additions & 12 deletions modules/underdogmediaBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,18 @@
import {
logMessage,
deepAccess,
flatten,
parseSizesInput,
getWindowSelf,
getWindowTop,
isGptPubadsDefined,
isSlotMatchingAdUnitCode,
logInfo,
logMessage,
logWarn,
getWindowSelf,
getWindowTop,
deepAccess
parseSizesInput
} from '../src/utils.js';
import {
config
} from '../src/config.js';
import {
registerBidder
} from '../src/adapters/bidderFactory.js';
import {config} from '../src/config.js';
import {registerBidder} from '../src/adapters/bidderFactory.js';

const BIDDER_CODE = 'underdogmedia';
const UDM_ADAPTER_VERSION = '7.30V';
const UDM_VENDOR_ID = '159';
Expand Down Expand Up @@ -377,7 +374,7 @@ function makeNotification(bid, mid, bidParam) {
url += `;version=${UDM_ADAPTER_VERSION}`;
url += ';cb=' + Math.random();
url += ';qqq=' + (1 / bid.cpm);
url += ';hbt=' + config.getConfig('_bidderTimeout');
url += ';hbt=' + config.getConfig('bidderTimeout');
url += ';style=adapter';
url += ';vis=' + encodeURIComponent(document.visibilityState);

Expand Down
5 changes: 2 additions & 3 deletions modules/vdoaiBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { getAdUnitSizes } from '../src/utils.js';
import {config} from '../src/config.js';
import {getAdUnitSizes} from '../src/utils.js';
import {registerBidder} from '../src/adapters/bidderFactory.js';
import {BANNER, VIDEO} from '../src/mediaTypes.js';

Expand Down Expand Up @@ -87,7 +86,7 @@ export const spec = {
// dealId: dealId,
currency: currency,
netRevenue: netRevenue,
ttl: config.getConfig('_bidderTimeout'),
ttl: 60,
// referrer: referrer,
// ad: response.adm
// ad: adCreative,
Expand Down
5 changes: 2 additions & 3 deletions modules/wipesBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { logWarn } from '../src/utils.js';
import {config} from '../src/config.js';
import {logWarn} from '../src/utils.js';
import {registerBidder} from '../src/adapters/bidderFactory.js';
import {BANNER} from '../src/mediaTypes.js';

Expand Down Expand Up @@ -50,7 +49,7 @@ function interpretResponse(serverResponse, bidRequest) {
dealId: response.deal_id,
currency: 'JPY',
netRevenue: netRevenue,
ttl: config.getConfig('_bidderTimeout'),
ttl: 60,
referrer: bidRequest.data.r || '',
mediaType: BANNER,
ad: response.ad_tag,
Expand Down
7 changes: 3 additions & 4 deletions modules/yieldoneBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import {deepAccess, isEmpty, isStr, logWarn, parseSizesInput} from '../src/utils.js';
import {config} from '../src/config.js';
import {registerBidder} from '../src/adapters/bidderFactory.js';
import { Renderer } from '../src/Renderer.js';
import { BANNER, VIDEO } from '../src/mediaTypes.js';
import {Renderer} from '../src/Renderer.js';
import {BANNER, VIDEO} from '../src/mediaTypes.js';

/**
* @typedef {import('../src/adapters/bidderFactory').Bid} Bid
Expand Down Expand Up @@ -147,7 +146,7 @@ export const spec = {
dealId: dealId,
currency: currency,
netRevenue: netRevenue,
ttl: config.getConfig('_bidderTimeout'),
ttl: 60,
referrer: referrer,
meta: {
advertiserDomains: response.adomain ? response.adomain : []
Expand Down