Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triplelift Bid Adapter: relax check on consentString before appending gdprApplies to usersyncs #9885

Merged
merged 22 commits into from
May 1, 2023
Merged

Triplelift Bid Adapter: relax check on consentString before appending gdprApplies to usersyncs #9885

Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
25664ce
TL-35335: Cast playbackmethod as array
patrickloughrey Mar 1, 2023
7307d1a
Merge pull request #72 from triplelift-internal/TL-35335-cast-playbac…
patrickloughrey Mar 1, 2023
ee90d99
Merge branch 'prebid:master' into master
nllerandi3lift Apr 14, 2023
3ee1e9b
Merge branch 'prebid:master' into master
patrickloughrey Apr 17, 2023
0ff06ab
Merge branch 'prebid:master' into master
patrickloughrey Apr 21, 2023
40dbe99
TL-36204: Copy tid to imp extension obj
patrickloughrey Apr 21, 2023
4291c1e
Added support for entire ortb2Imp obj
patrickloughrey Apr 24, 2023
feecf24
Only setting what exists in ortb2Imp.ext
patrickloughrey Apr 24, 2023
a709f3f
Added additional test to check copy of entire ext obj
patrickloughrey Apr 24, 2023
49ba6a9
Merge pull request #74 from triplelift-internal/TL-36204-Copy-TID
patrickloughrey Apr 25, 2023
cd65aba
Merge branch 'prebid:master' into master
patrickloughrey Apr 25, 2023
b362e3a
Revert "TL-36204: Copy tid to imp extension object"
patrickloughrey Apr 25, 2023
5574ef5
Merge pull request #75 from triplelift-internal/revert-74-TL-36204-Co…
patrickloughrey Apr 25, 2023
cfba68c
TL-36204: Copying ortb2Imp.ext to impression ext obj
patrickloughrey Apr 25, 2023
13cab1f
Added edge case logic and additional test
patrickloughrey Apr 26, 2023
f074dc0
recos for tid change
nllerandi3lift Apr 27, 2023
0b4d931
merge conflict
nllerandi3lift Apr 27, 2023
e8c6bd1
Added spread operator to replace deepClone
patrickloughrey Apr 27, 2023
f4a6c93
Merge pull request #77 from triplelift-internal/TL-36204-Copy-Imp-Ext
patrickloughrey Apr 27, 2023
4262b7f
Merge branch 'prebid:master' into master
patrickloughrey Apr 27, 2023
43fbffd
Merge branch 'prebid:master' into master
nllerandi3lift May 1, 2023
be4c3ea
addresses gdprApplies
nllerandi3lift May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions modules/tripleliftBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const BIDDER_CODE = 'triplelift';
const STR_ENDPOINT = 'https://tlx.3lift.com/header/auction?';
const BANNER_TIME_TO_LIVE = 300;
const VIDEO_TIME_TO_LIVE = 3600;
let gdprApplies = true;
let gdprApplies = null;
let consentString = null;
export const storage = getStorageManager({bidderCode: BIDDER_CODE});

Expand Down Expand Up @@ -40,8 +40,12 @@ export const tripleliftAdapterSpec = {
if (bidderRequest && bidderRequest.gdprConsent) {
if (typeof bidderRequest.gdprConsent.gdprApplies !== 'undefined') {
gdprApplies = bidderRequest.gdprConsent.gdprApplies;
tlCall = tryAppendQueryString(tlCall, 'gdpr', gdprApplies.toString());
} else {
gdprApplies = true;
}

tlCall = tryAppendQueryString(tlCall, 'gdpr', gdprApplies.toString());

if (typeof bidderRequest.gdprConsent.consentString !== 'undefined') {
consentString = bidderRequest.gdprConsent.consentString;
tlCall = tryAppendQueryString(tlCall, 'cmp_cs', consentString);
Expand Down Expand Up @@ -87,7 +91,7 @@ export const tripleliftAdapterSpec = {
syncEndpoint = tryAppendQueryString(syncEndpoint, 'src', 'prebid');
}

if (consentString !== null) {
if (consentString !== null || gdprApplies) {
syncEndpoint = tryAppendQueryString(syncEndpoint, 'gdpr', gdprApplies);
syncEndpoint = tryAppendQueryString(syncEndpoint, 'cmp_cs', consentString);
}
Expand Down