Utiq user sub-module: Remove unused domain assingment #9995
Conversation
…ess of message events
…onyms refactor: Update trustpid acronyms logic
|
@ChrisHuie As all of the checks are now passing, can we move forward with this PR? |
|
Please merge and publish ideally together with prebid/prebid.github.io#4528. |
|
@Utiq-tech @jkthomas the module deletions need to go in a major version release pr. I saw the one on prebid 8 but doesn't look to include the removing of the old module. Since that is a breaking change for users can you put the deletions in a separate pr on the prebid 8 branch and take them out of this pr. Or just hold off a few weeks and Prebid 8 should be released and we can sync this with prebid 8 release and the previously merged pr. |
|
@ChrisHuie So the #9872 was the renaming PR, since we were migrating the solution to the new name and all parties that had been using our module were already notified. This one is targeting the |
|
yes please, but perhaps create a new branch based on prebid 8 and then pr the prebid 8 branch with the changes, that should be cleaner; or clean up this one so the changeset is confined to what you're trying to do here |
|
Did as suggested by both of you, I cleaned the commit history and moved it to #10044, targeting |
Type of change
Description of change
Removal of domain checks which became irrelevant due to the data layer changes.
Other information
This change is supposed to go together with the renaming changes introduced in #9872, merged to Prebid 8 branch.