Update GVL parser tests to ensure support for GVL specification versi…

…on 3 (#36)
prebid · Jun 14, 2023 · b1cf544 · b1cf544
1 parent ca19899
commit b1cf544
Show file tree

Hide file tree

Showing 3 changed files with 256 additions and 101 deletions.
diff --git a/vendorlist2/eager-parsing_test.go b/vendorlist2/eager-parsing_test.go
@@ -3,33 +3,64 @@ package vendorlist2
 import (
 	"testing"
 
-	"github.com/prebid/go-gdpr/api"
 	"github.com/stretchr/testify/assert"
 )
 
-func TestEagerlyParsedVendorList(t *testing.T) {
-	AssertVendorlistCorrectness(t, func(data []byte) api.VendorList {
-		vendorList, err := ParseEagerly(data)
-		if err != nil {
-			t.Errorf("ParseEagerly returned an unexpected error: %v", err)
-		}
-		return vendorList
-	})
-}
+func TestParseEagerlyVendorList(t *testing.T) {
+	tests := []struct{
+		name              string
+		vendorList        string
+		vendorListVersion uint16
+	}{
+		{
+			name:       "vendor list spec 2",
+			vendorList: testDataSpecVersion2,
+			vendorListVersion: 28,
+		},
+		{
+			name:       "vendor list spec 3",
+			vendorList: testDataSpecVersion3,
+			vendorListVersion: 1,
+		},
+	}
 
-func TestParseEagerlyVendorsEmpty(t *testing.T) {
-	vendorListJSON := `
-{
-	"gvlSpecificationVersion": 2,
-	"vendorListVersion": 28,
-	"tcfPolicyVersion": 2,
-	"lastUpdated": "2020-03-05T16:05:29Z",
-	"vendors": { }
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			parsedGVL, err := ParseEagerly([]byte(tt.vendorList))
+			assert.NoError(t, err)
+			assert.Equal(t, tt.vendorListVersion, parsedGVL.Version())
+			assert.NotNil(t, parsedGVL.Vendor(8))
+			assert.NotNil(t, parsedGVL.Vendor(80))
+			AssertVendorListCorrectness(t, parsedGVL)
+		})
+	}
 }
-`
-	vendorList, err := ParseEagerly([]byte(vendorListJSON))
 
-	assert.NoError(t, err)
-	assert.Equal(t, vendorList.Version(), uint16(28))
-	assert.Nil(t, vendorList.Vendor(0))
+func TestParseEagerlyEmptyVendorList(t *testing.T) {
+	tests := []struct{
+		name              string
+		vendorList        string
+		vendorListVersion uint16
+	}{
+		{
+			name:       "vendor list spec 2",
+			vendorList: testDataSpecVersion2Empty,
+			vendorListVersion: 28,
+		},
+		{
+			name:       "vendor list spec 3",
+			vendorList: testDataSpecVersion3Empty,
+			vendorListVersion: 1,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			parsedGVL, err := ParseEagerly([]byte(tt.vendorList))
+			assert.NoError(t, err)
+			assert.Equal(t, tt.vendorListVersion, parsedGVL.Version())
+			assert.Nil(t, parsedGVL.Vendor(8))
+			assert.Nil(t, parsedGVL.Vendor(80))
+		})
+	}
 }
diff --git a/vendorlist2/lazy-parsing_test.go b/vendorlist2/lazy-parsing_test.go
@@ -2,8 +2,63 @@ package vendorlist2
 
 import (
 	"testing"
+
+	"github.com/stretchr/testify/assert"
 )
 
-func TestLazyParsedVendorList(t *testing.T) {
-	AssertVendorlistCorrectness(t, ParseLazily)
+func TestParseLazilyVendorList(t *testing.T) {
+	tests := []struct{
+		name              string
+		vendorList        string
+		vendorListVersion uint16
+	}{
+		{
+			name:       "vendor list spec 2",
+			vendorList: testDataSpecVersion2,
+			vendorListVersion: 28,
+		},
+		{
+			name:       "vendor list spec 3",
+			vendorList: testDataSpecVersion3,
+			vendorListVersion: 1,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			parsedGVL := ParseLazily([]byte(tt.vendorList))
+			assert.Equal(t, tt.vendorListVersion, parsedGVL.Version())
+			assert.NotNil(t, parsedGVL.Vendor(8))
+			assert.NotNil(t, parsedGVL.Vendor(80))
+			AssertVendorListCorrectness(t, parsedGVL)
+		})
+	}
+}
+
+func TestParseLazilyEmptyVendorList(t *testing.T) {
+	tests := []struct{
+		name              string
+		vendorList        string
+		vendorListVersion uint16
+	}{
+		{
+			name:       "vendor list spec 2",
+			vendorList: testDataSpecVersion2Empty,
+			vendorListVersion: 28,
+		},
+		{
+			name:       "vendor list spec 3",
+			vendorList: testDataSpecVersion3Empty,
+			vendorListVersion: 1,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			parsedGVL := ParseLazily([]byte(tt.vendorList))
+			assert.Equal(t, tt.vendorListVersion, parsedGVL.Version())
+			assert.Nil(t, parsedGVL.Vendor(8))
+			assert.Nil(t, parsedGVL.Vendor(80))
+		})
+	}
 }