Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle GPP Base64 Quantum Quirks #13

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Handle GPP Base64 Quantum Quirks #13

merged 1 commit into from
Jan 22, 2024

Conversation

SyntaxNode
Copy link
Contributor

Fixes #12

SyntaxNode
SyntaxNode commented Jan 17, 2024
View reviewed changes
parse_test.go
"GPP-tcf": {
"gpp-tcf": {
description: "GPP string with EU TCF V2",
gppString: "DBABM~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA",
Copy link
Contributor Author

@SyntaxNode SyntaxNode Jan 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated examples to exactly match GPP docs. Somewhere along the way we added extra padding to those examples, which caused us to overlook this bug.

SyntaxNode
SyntaxNode commented Jan 17, 2024
View reviewed changes
parse_test.go
description: "GPP string with USPCA",
gppString: "DBABBgA~xlgWE",
expectedError: []error{fmt.Errorf("error parsing uspca consent string: illegal base64 data at input byte 4")},
expectedError: []error{fmt.Errorf("error parsing uspca consent string: unable to set field CoreSegment.SensitiveDataProcessing due to parse error: expected 2 bits to start at bit 32, but the byte array was only 4 bytes long")},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It failed for the wrong reason before. Fixed expectation.

hhhjort
hhhjort approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SyntaxNode SyntaxNode merged commit 2cc0862 into prebid:main Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeronikaSolovei9 VeronikaSolovei9 VeronikaSolovei9 approved these changes

@hhhjort hhhjort hhhjort approved these changes

Assignees

@VeronikaSolovei9 VeronikaSolovei9

@hhhjort hhhjort

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header parsing does not work as expected
3 participants
@SyntaxNode @VeronikaSolovei9 @hhhjort