Better parse error handling #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
reviewed
Feb 28, 2023
constants/constants.go
Outdated
| @@ -13,3 +13,6 @@ const ( | |||
| SectionUSPUT SectionID = 11 | |||
| SectionUSPCT SectionID = 12 | |||
| ) | |||
|
|
|||
| var SectionIDNames = []string{"ID0", "ID1", "tcfeu2", "gpp header", "ID4", "ID5", "uspv1", "uspnat", | |||
| "uspca", "uspva", "uspco", "usput", "uspct"} | |||
There was a problem hiding this comment.
IMHO: It's a bit odd to see names set for the value 0 which is undefined. There are names for sections 1, 4, and 5 - but they're not supported by this library. Based on how the function is used, it's save to ignore values for which are not parsed.
How do you feel about using a map for supported sections?
var sectionNamesByID = map[int]string{
2: "tcfeu2",
3: "gpp header",
...
}
| }, | ||
| expectedError: []error{fmt.Errorf("error parsing GPP header, section identifiers: error reading an int offset value in a Range(Fibonacci) entry(1): error reading bit 4 of Integer(Fibonacci): expected 1 bit at bit 32, but the byte array was only 4 bytes long")}, | ||
| }, | ||
| "GPP-uspca-error": { |
SyntaxNode
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.