Impression tracker for original API #804
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More verbose logs.
8 tasks
YuriyVelichkoPI
requested changes
Nov 20, 2024
| @@ -449,6 +477,8 @@ public void onFetchCompleted(BidResponse response) { | |||
| HashMap<String, String> keywords = response.getTargeting(); | |||
| Util.apply(keywords, adObject); | |||
| originalListener.onComplete(ResultCode.SUCCESS); | |||
|
|
|||
| registerVisibilityTrackerIfNeeded(bidResponse); | |||
There was a problem hiding this comment.
This approach doesn't look reliable. Switching the tracker on/off for each result of the bid fetching may lead to gaps in tracking.
Let's implement it in the following.
- start viewability tracking on calling of
activatePrebidImpressionTracker - stop tracking on destroying the AdUnit object
- once the tracked view meets the impression tracking criteria - check the content, and if it contains PUC - track the respective impression.
| @@ -65,7 +72,11 @@ public abstract class AdUnit { | |||
| @Nullable | |||
| protected BidResponse bidResponse; | |||
|
|
|||
| protected final VisibilityMonitor visibilityMonitor = new VisibilityMonitor(); | |||
| protected WeakReference<View> adViewReference = new WeakReference<>(null); | |||
There was a problem hiding this comment.
Can we hold adViewReference in VisibilityMonitor?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.