Fixed VAST matching.

prebid · Oct 9, 2024 · 1a39c76 · 1a39c76
1 parent e00b80c
commit 1a39c76
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...s/modules/pb/response/correction/core/correction/appvideohtml/AppVideoHtmlCorrection.java b/...s/modules/pb/response/correction/core/correction/appvideohtml/AppVideoHtmlCorrection.java
@@ -21,6 +21,7 @@
 
 import java.util.Collection;
 import java.util.List;
+import java.util.Objects;
 import java.util.Optional;
 import java.util.regex.Pattern;
 
@@ -29,7 +30,7 @@ public class AppVideoHtmlCorrection implements Correction {
     private static final ConditionalLogger conditionalLogger = new ConditionalLogger(
             LoggerFactory.getLogger(AppVideoHtmlCorrection.class));
 
-    private static final Pattern VAST_XML_PATTERN = Pattern.compile("<\\w*VAST\\w+", Pattern.CASE_INSENSITIVE);
+    private static final Pattern VAST_XML_PATTERN = Pattern.compile("<\\s*VAST.+>", Pattern.CASE_INSENSITIVE);
     private static final TypeReference<ExtPrebid<ExtBidPrebid, ObjectNode>> EXT_BID_PREBID_TYPE_REFERENCE =
             new TypeReference<>() {
             };
@@ -42,7 +43,7 @@ public class AppVideoHtmlCorrection implements Correction {
     private final double logSamplingRate;
 
     public AppVideoHtmlCorrection(ObjectMapper mapper, double logSamplingRate) {
-        this.mapper = mapper;
+        this.mapper = Objects.requireNonNull(mapper);
         this.logSamplingRate = logSamplingRate;
     }
 

diff --git a/...dules/pb/response/correction/core/correction/appvideohtml/AppVideoHtmlCorrectionTest.java b/...dules/pb/response/correction/core/correction/appvideohtml/AppVideoHtmlCorrectionTest.java
@@ -77,7 +77,7 @@ public void applyShouldNotChangeBidResponsesWhenBidIsVideoAndHasVastXmlInAdm() {
         final List<BidderResponse> givenResponses = List.of(
                 BidderResponse.of("bidderA", null, 100),
                 BidderResponse.of("bidderB", BidderSeatBid.of(
-                        List.of(givenBid("<anythingvAstanything", BidType.video))), 100));
+                        List.of(givenBid("< \tVAST anything>", BidType.video))), 100));
 
         // when
         final List<BidderResponse> actual = target.apply(givenConfig, givenResponses);