Respond from NotificationEventHandler when analytics disabled (#1014)

prebid · Nov 17, 2020 · 54bb1ad · 54bb1ad
1 parent e087682
commit 54bb1ad
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/main/java/org/prebid/server/handler/NotificationEventHandler.java b/src/main/java/org/prebid/server/handler/NotificationEventHandler.java
@@ -90,6 +90,8 @@ public void handle(RoutingContext context) {
         if (eventRequest.getAnalytics() == EventRequest.Analytics.enabled) {
             getAccountById(eventRequest.getAccountId())
                     .setHandler(async -> handleEvent(async, eventRequest, context));
+        } else {
+            respondWithOkStatus(context, eventRequest.getFormat() == EventRequest.Format.image);
         }
     }
 

diff --git a/src/test/java/org/prebid/server/handler/NotificationEventHandlerTest.java b/src/test/java/org/prebid/server/handler/NotificationEventHandlerTest.java
@@ -36,6 +36,7 @@
 import static org.mockito.ArgumentMatchers.anyInt;
 import static org.mockito.ArgumentMatchers.anyString;
 import static org.mockito.BDDMockito.given;
+import static org.mockito.Mockito.never;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.verifyNoMoreInteractions;
 import static org.mockito.Mockito.verifyZeroInteractions;
@@ -302,6 +303,23 @@ public void shouldNotPassEventToAnalyticsReporterWhenAnalyticsValueIsZero() {
         verifyZeroInteractions(analyticsReporter);
     }
 
+    @Test
+    public void shouldRespondWhenAnalyticsValueIsZeroAndDoNotSetStatusManually() {
+        // given
+        given(httpRequest.params()).willReturn(MultiMap.caseInsensitiveMultiMap()
+                .add("t", "win")
+                .add("b", "bidId")
+                .add("a", "accountId")
+                .add("x", "0"));
+
+        // when
+        notificationHandler.handle(routingContext);
+
+        // then
+        verify(httpResponse, never()).setStatusCode(anyInt());
+        verify(httpResponse).end();
+    }
+
     @Test
     public void shouldRespondWithPixelAndContentTypeWhenRequestFormatIsImp() throws IOException {
         // given