Fixed unwanted VAST XML linebreaks (#1952)

prebid · Jul 15, 2022 · 6f5f4a0 · 6f5f4a0
1 parent a264a2b
commit 6f5f4a0
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 18 deletions.
diff --git a/src/main/java/org/prebid/server/vast/VastModifier.java b/src/main/java/org/prebid/server/vast/VastModifier.java
@@ -94,10 +94,10 @@ public String createBidVastXml(String bidder,
     private static String resolveVastXmlFrom(String bidAdm, String bidNurl) {
         return StringUtils.isEmpty(bidAdm) && bidNurl != null
                 ? """
-                <VAST version="3.0"><Ad><Wrapper>
-                <AdSystem>prebid.org wrapper</AdSystem>
-                <VASTAdTagURI><![CDATA[%s]]></VASTAdTagURI>
-                <Creatives></Creatives>
+                <VAST version="3.0"><Ad><Wrapper>\
+                <AdSystem>prebid.org wrapper</AdSystem>\
+                <VASTAdTagURI><![CDATA[%s]]></VASTAdTagURI>\
+                <Creatives></Creatives>\
                 </Wrapper></Ad></VAST>""".formatted(bidNurl)
                 : bidAdm;
     }

diff --git a/src/test/java/org/prebid/server/vast/VastModifierTest.java b/src/test/java/org/prebid/server/vast/VastModifierTest.java
@@ -109,10 +109,13 @@ public void modifyVastXmlShouldModifyVastAndAppendUrl() {
                 INTEGRATION);
 
         // then
-        final String modifiedVast = "<VAST version=\"3.0\"><Ad><Wrapper><AdSystem>prebid.org wrapper</AdSystem>"
-                + "<VASTAdTagURI><![CDATA[adm2]]></VASTAdTagURI><Impression></Impression>"
-                + "<Impression><![CDATA[http://external-url/event]]></Impression>"
-                + "<Creatives></Creatives></Wrapper></Ad></VAST>";
+        final String modifiedVast =
+                """
+                <VAST version="3.0"><Ad><Wrapper><AdSystem>prebid.org wrapper</AdSystem>\
+                <VASTAdTagURI><![CDATA[adm2]]></VASTAdTagURI><Impression></Impression>\
+                <Impression><![CDATA[http://external-url/event]]></Impression><Creatives>\
+                </Creatives></Wrapper></Ad></VAST>\
+                """;
 
         assertThat(result).isEqualTo(new TextNode(modifiedVast));
     }
@@ -341,20 +344,23 @@ private static TextNode nodeAdm() {
     }
 
     public static String adm() {
-        return "<VAST version=\"3.0\"><Ad><Wrapper>"
-                + "<AdSystem>prebid.org wrapper</AdSystem>"
-                + "<VASTAdTagURI><![CDATA[adm2]]></VASTAdTagURI>"
-                + "<Impression></Impression><Creatives></Creatives>"
-                + "</Wrapper></Ad></VAST>";
+        return """
+                <VAST version="3.0"><Ad><Wrapper>\
+                <AdSystem>prebid.org wrapper</AdSystem><VASTAdTagURI>\
+                <![CDATA[adm2]]></VASTAdTagURI><Impression>\
+                </Impression><Creatives></Creatives>\
+                </Wrapper></Ad></VAST>\
+                """;
     }
 
     private static String modifiedAdm(String bidNurl) {
         return """
-                <VAST version="3.0"><Ad><Wrapper>
-                <AdSystem>prebid.org wrapper</AdSystem>
-                <VASTAdTagURI><![CDATA[%s]]></VASTAdTagURI>
-                <Creatives></Creatives>
-                </Wrapper></Ad></VAST>""".formatted(bidNurl);
+                <VAST version="3.0"><Ad><Wrapper>\
+                <AdSystem>prebid.org wrapper</AdSystem>\
+                <VASTAdTagURI><![CDATA[%s]]></VASTAdTagURI>\
+                <Creatives></Creatives>\
+                </Wrapper></Ad></VAST>\
+                """.formatted(bidNurl);
     }
 
     private static EventsContext givenEventsContext(boolean accountEnabled) {