Skip to content

Commit

Permalink
Fixes after review
Browse files Browse the repository at this point in the history
  • Loading branch information
rpanchyk committed Jun 15, 2021
1 parent e384352 commit 77ff45c
Showing 1 changed file with 1 addition and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -62,15 +62,9 @@ public AdgenerationBidder(String endpointUrl, JacksonMapper mapper) {

@Override
public Result<List<HttpRequest<Void>>> makeHttpRequests(BidRequest request) {
final List<Imp> imps = request.getImp();

if (CollectionUtils.isEmpty(imps)) {
return Result.withError(BidderError.badInput("No impression in the bid request"));
}

final List<HttpRequest<Void>> requests = new ArrayList<>();
final List<BidderError> errors = new ArrayList<>();
for (Imp imp : imps) {
for (Imp imp : request.getImp()) {
try {
final ExtImpAdgeneration extImpAdgeneration = parseAndValidateImpExt(imp);
final String adgenerationId = extImpAdgeneration.getId();
Expand Down

0 comments on commit 77ff45c

Please sign in to comment.