Outbrain adapter: overwrite tagid only if it exists (#1358)

prebid · Aug 10, 2021 · b3dfa7f · b3dfa7f
1 parent 5ab95bc
commit b3dfa7f
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 3 deletions.
diff --git a/src/main/java/org/prebid/server/bidder/outbrain/OutbrainBidder.java b/src/main/java/org/prebid/server/bidder/outbrain/OutbrainBidder.java
@@ -98,9 +98,9 @@ private ExtImpOutbrain parseImpExt(Imp imp) {
     }
 
     private static Imp modifyImp(Imp imp, String tagId) {
-        return imp.toBuilder()
-                .tagid(tagId)
-                .build();
+        return StringUtils.isNotEmpty(tagId)
+                ? imp.toBuilder().tagid(tagId).build()
+                : imp;
     }
 
     private static BidRequest updateBidRequest(BidRequest bidRequest, List<Imp> imps, ExtImpOutbrain extImpOutbrain) {

diff --git a/src/test/java/org/prebid/server/bidder/outbrain/OutbrainBidderTest.java b/src/test/java/org/prebid/server/bidder/outbrain/OutbrainBidderTest.java
@@ -71,6 +71,38 @@ public void makeHttpRequestsShouldCreateOneSingleRequestWithAllImps() {
                 .hasSize(2);
     }
 
+    @Test
+    public void makeHttpRequestsShouldModifyImpTagIdOnlyIfItPresentInExt() {
+        // given
+        final Imp firstImp = Imp.builder()
+                .id("123")
+                .tagid("123")
+                .ext(mapper.valueToTree(ExtPrebid.of(null, ExtImpOutbrain.of(
+                        ExtImpOutbrainPublisher.of("testId", "testName", "testDomain"),
+                        null, singletonList("testBcat"), singletonList("testBadv")))))
+                .build();
+
+        final Imp thirdImp = Imp.builder()
+                .id("789")
+                .tagid("789")
+                .ext(mapper.valueToTree(ExtPrebid.of(null, ExtImpOutbrain.of(
+                        ExtImpOutbrainPublisher.of("testId", "testName", "testDomain"),
+                        "098", singletonList("testBcat"), singletonList("testBadv")))))
+                .build();
+
+        final BidRequest bidRequest = BidRequest.builder().imp(asList(firstImp, thirdImp)).build();
+
+        // when
+        final Result<List<HttpRequest<BidRequest>>> result = outbrainBidder.makeHttpRequests(bidRequest);
+
+        // then
+        assertThat(result.getErrors()).isEmpty();
+        assertThat(result.getValue())
+                .extracting(HttpRequest::getPayload)
+                .flatExtracting(BidRequest::getImp)
+                .containsExactlyInAnyOrder(firstImp, thirdImp.toBuilder().tagid("098").build());
+    }
+
     @Test
     public void makeHttpRequestsShouldUpdatePresentedAppWithPublisherParamsFromExt() {
         // given