Criteo: Update Json validation schema and maintainer email (#1337)

prebid · Jul 8, 2021 · b64ac2d · b64ac2d
1 parent c5f461a
commit b64ac2d
Show file tree

Hide file tree

Showing 4 changed files with 47 additions and 15 deletions.
diff --git a/src/main/java/org/prebid/server/proto/openrtb/ext/request/ExtImpCriteo.java b/src/main/java/org/prebid/server/proto/openrtb/ext/request/ExtImpCriteo.java
@@ -1,5 +1,6 @@
 package org.prebid.server.proto.openrtb.ext.request;
 
+import com.fasterxml.jackson.annotation.JsonAlias;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import lombok.AllArgsConstructor;
 import lombok.Value;
@@ -9,9 +10,10 @@
 public class ExtImpCriteo {
 
     @JsonProperty("zoneId")
+    @JsonAlias({"zoneid"})
     Integer zoneId;
 
     @JsonProperty("networkId")
+    @JsonAlias({"networkid"})
     Integer networkId;
-
 }
diff --git a/src/main/resources/bidder-config/criteo.yaml b/src/main/resources/bidder-config/criteo.yaml
@@ -9,7 +9,7 @@ adapters:
     deprecated-names:
     aliases: {}
     meta-info:
-      maintainer-email: pi-direct@criteo.com
+      maintainer-email: prebid@criteo.com
       app-media-types:
         - banner
       site-media-types:

diff --git a/src/main/resources/static/bidder-params/criteo.json b/src/main/resources/static/bidder-params/criteo.json
@@ -1,20 +1,50 @@
 {
   "$schema": "http://json-schema.org/draft-04/schema#",
-  "title": "Criteo Adapter Params",
-  "description": "A schema which validates params accepted by the Criteo adapter",
-
+  "title": "Criteo adapter params",
+  "description": "The schema to validate Criteo specific params accepted by Criteo adapter",
   "type": "object",
   "properties": {
+    "zoneid": {
+      "type": "integer",
+      "description": "Impression's zone ID.",
+      "minimum": 0
+    },
     "zoneId": {
-      "type": "number",
-      "description": "The zone ID from Criteo",
-      "pattern": "^[0-9]+$"
+      "type": "integer",
+      "description": "Impression's zone ID, preferred.",
+      "minimum": 0
+    },
+    "networkid": {
+      "type": "integer",
+      "description": "Impression's network ID.",
+      "minimum": 0
     },
     "networkId": {
-      "type": "number",
-      "description": "The network ID from Criteo",
-      "pattern": "^[0-9]+$"
+      "type": "integer",
+      "description": "Impression's network ID, preferred.",
+      "minimum": 0
     }
   },
-  "required": ["zoneId", "networkId"]
-}
+  "anyOf": [
+    {
+      "required": [
+        "zoneid"
+      ]
+    },
+    {
+      "required": [
+        "zoneId"
+      ]
+    },
+    {
+      "required": [
+        "networkid"
+      ]
+    },
+    {
+      "required": [
+        "networkId"
+      ]
+    }
+  ]
+}
diff --git a/src/test/resources/org/prebid/server/it/openrtb2/criteo/test-auction-criteo-request.json b/src/test/resources/org/prebid/server/it/openrtb2/criteo/test-auction-criteo-request.json
@@ -16,7 +16,7 @@
       "ext": {
         "criteo": {
           "zoneId": 123456,
-          "networkId": 78910
+          "networkid": 78910
         }
       }
     }
@@ -73,4 +73,4 @@
       "us_privacy": "1YNN"
     }
   }
-}
+}