Add support for CPM override in Rubicon bidder - fix after review

prebid · May 25, 2020 · b715ed0 · b715ed0
1 parent 6464a3c
commit b715ed0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/docs/pbs-java-and-go-features-review.md b/docs/pbs-java-and-go-features-review.md
@@ -4,21 +4,21 @@
 
  Feature | Java | Go 
 | --- | :---: | :---:|
-First Party data |+|-
+First Party Data |+|-
 Stored Requests |+|+
 Stored Responses |+|-
 Currency Conversion** |+|+
-Geo location (used for GDPR) |+|-
-Circuit Breaker (Http, DB) |+|-
-Passing Bidder ext in `imp[...].ext.prebid.bidder` |-|+
-Passing `request.ext.prebid.bidders.BIDDER` to corresponding bidder |+|-
+Geo Location (used for GDPR) |+|-
+Circuit Breaker (HTTP, DB) |+|-
+Passing Bidder extension in `imp[i].ext.prebid.bidder` |+|+
+Passing `ext.prebid.bidders.BIDDER` to corresponding bidder |+|-
 Media Type Price Granularity |+|-
 Cache only-winning-bids flag |+|-
 User ID Module |+|+
 Bid Categories |-|+
 Apps/Accounts Blacklist  |+|+
 Event Notification endpoint |+|-
-Video Auction endpoint |-|+
+Video Auction endpoint |+|+
 Video Impression Tracking endpoint |+|-
 GDPR |+|+
 COPPA |+|+

diff --git a/src/main/java/org/prebid/server/bidder/rubicon/RubiconBidder.java b/src/main/java/org/prebid/server/bidder/rubicon/RubiconBidder.java
@@ -788,6 +788,7 @@ private Bid updateBid(Bid bid, Imp imp, Float cmpOverrideFromRequest, BidRespons
             bid.setId(bidResponse.getBidid());
         }
 
+        // Unconditionally set price if coming from CPM override
         final Float cpmOverride = ObjectUtils.defaultIfNull(cpmOverrideFromImp(imp), cmpOverrideFromRequest);
         if (cpmOverride != null) {
             bid.setPrice(new BigDecimal(String.valueOf(cpmOverride)));