Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow gzip compress for BidRequest/BidResponse between prebid server and bidders #1304

Closed
vriffier opened this issue Jun 8, 2021 · 7 comments
Assignees

Comments

@vriffier
Copy link

vriffier commented Jun 8, 2021

Hello,

The prebid-server go is implementing this prebid/prebid-server#1812 compression.

Is there any plan on implementing the same thing for the prebid-server-java project?
Are there any bidder who can already read/interpret compressed bidrequest?
Any date on making this available?

Thanks,

@rpanchyk
Copy link
Contributor

rpanchyk commented Jun 8, 2021

This one?
#1284

@rpanchyk rpanchyk self-assigned this Jun 9, 2021
@vriffier
Copy link
Author

vriffier commented Jun 9, 2021

No from my understanding you're referring to response decompression whereas I was looking into request compression from PBS to Bidders

@rpanchyk
Copy link
Contributor

rpanchyk commented Jun 9, 2021

We've global property for all outgoing requests - http-client.use-compression.
Full list - https://github.com/prebid/prebid-server-java/blob/master/docs/config-app.md#http-client
So, seems it is not possible to turn on for individual bidder (or request) since PBS uses only a few instances of HttpClient.

@WalterT
Copy link

WalterT commented Jun 15, 2021

Hi @rpanchyk,

Sorry we are a bit unclear here :)

  • Are you saying that it is possible to compress outgoing requests from the server to bidders using http-client.use-compression? Because we tested http-client.use-compression=true and it seems only to be used by bidders to compress their responses but it does not compress outgoing requests. Am I understanding this well? Or is that config supposed to be already compressing outgoing requests?

  • If not possible, is this something meant to be implemented here: Allow gzip compress for BidRequest backend communication with bidders prebid-server#1812 ? (Question is for both Go and Java projects).

  • Would any bidder be able to read compressed requests?

Thanks a lot for your help and sorry if this is already mentioned somewhere else! We are a bit struggling to be clear on this topic

@rpanchyk
Copy link
Contributor

hey @WalterT you're right - let me clarify.

Case 1: bidder responds to PBS with compressed body - if you set http-client.use-compression=true PBS will add ACCEPT_ENCODING header as described here - #288 (comment)
So, bidder exchange can respond with compressed body and PBS will decompress it.

Case 2: PBS requests bidder endpoint with compressed body - this one is not ready yet, but issue you've mentioned (prebid/prebid-server#1812) would be implemented in near future (sorry, no terms so far).
Please follow that issue for any updates on this case.

@WalterT
Copy link

WalterT commented Jun 23, 2021

Hi @rpanchyk,

That's clear, thanks a lot for this!

@rpanchyk
Copy link
Contributor

Sure, closing this. Feel free to open new if any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants