Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable compression between PBS and bidders #288

Closed
mikiescolarmrf opened this issue Feb 21, 2019 · 1 comment · Fixed by #289
Closed

Enable compression between PBS and bidders #288

mikiescolarmrf opened this issue Feb 21, 2019 · 1 comment · Fixed by #289

Comments

@mikiescolarmrf
Copy link
Contributor

We have found that Vert.x HttpClient supports compression in responses. We think that we could configure BasicHttpClient to use this feature.

Once activated, we expect a performance improvement between PBS and bidders.

BTW, do you think this feature should be configurable?

@rpanchyk
Copy link
Contributor

Thank you for bringing it up, @mikiescolarmrf !
It's a cool feature and we can enable it in HttpClientOptions for HttpClient.

While sending the request HttpClient will check this option and add accept-encoding header.
From vertx-core-3.6.2-sources.jar!/io/vertx/core/http/impl/Http1xClientConnection.java:

if (conn.options.isTryUseCompression() && request.headers().get(ACCEPT_ENCODING) == null) {
  // if compression should be used but nothing is specified by the user support deflate and gzip.
  request.headers().set(ACCEPT_ENCODING, DEFLATE_GZIP);
}

To be PBS flexible, we think it should be configurable, like http-client.use-compression with true|false values available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants