Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GumGum bidder review #1059

Merged
merged 3 commits into from
Dec 8, 2020
Merged

GumGum bidder review #1059

merged 3 commits into from
Dec 8, 2020

Conversation

SerhiiNahornyi
Copy link
Collaborator

No description provided.

rpanchyk
rpanchyk previously approved these changes Dec 8, 2020
View reviewed changes
src/main/java/org/prebid/server/bidder/gumgum/GumgumBidder.java Outdated Show resolved Hide resolved
@rpanchyk rpanchyk requested a review from DGarbar December 8, 2020 13:10
@DGarbar
Copy link
Contributor

DGarbar commented Dec 8, 2020

Probably we need to add } else if (imp.getVideo() != null) { to the 89 line and remove 91 line.
And extract video and banner in try catch

@SerhiiNahornyi
Copy link
Collaborator Author

Probably we need to add } else if (imp.getVideo() != null) { to the 89 line and remove 91 line.
And extract video and banner in try catch

Don't think so because using without if, gives us opportunity to use created video variable then

@rpanchyk rpanchyk mentioned this pull request Dec 8, 2020
Merged
@rpanchyk rpanchyk merged commit 1badbe3 into master Dec 8, 2020
@rpanchyk rpanchyk deleted the gumgum/review branch December 8, 2020 14:38
nickluck9 pushed a commit that referenced this pull request Aug 9, 2021
@SerhiiNahornyi
GumGum bidder review (#1059)
3878a25
nickluck9 pushed a commit that referenced this pull request Aug 10, 2021
@SerhiiNahornyi
GumGum bidder review (#1059)
51657fc
nickluck9 pushed a commit that referenced this pull request Aug 10, 2021
@SerhiiNahornyi
GumGum bidder review (#1059)
82254c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpanchyk rpanchyk rpanchyk approved these changes

@DGarbar DGarbar DGarbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SerhiiNahornyi @DGarbar @rpanchyk