Bugfix POST requests with Adhese adapter #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNahornyi
suggested changes
Feb 10, 2021
src/main/java/org/prebid/server/bidder/adhese/model/AdheseRequestBody.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/adhese/AdheseBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/adhese/AdheseBidder.java
Outdated
Show resolved
Hide resolved
| .withHeader("Accept", WireMock.equalTo("application/json")) | ||
| .withHeader("Content-Type", WireMock.equalTo("application/json;charset=UTF-8")) | ||
| .withRequestBody(WireMock.absent()) | ||
| .withRequestBody(WireMock.equalToJson("{\"slots\":[{\"slotname\":\"_adhese_prebid_demo_-leaderboard\"}],\"parameters\":{\"ag\":[\"55\"],\"ci\":[\"gent\",\"brussels\"],\"tl\":[\"all\"],\"xt\":[\"consentValue\"],\"xf\":[\"http://www.example.com\"],\"xz\":[\"ifaId\"]}}")) |
There was a problem hiding this comment.
Should we create json file with this body?
.withRequestBody(WireMock.equalToJson(jsonFrom("openrtb2/adhese/adheese-request-body.json")))
There was a problem hiding this comment.
@sander-adhese Agree with the above?
src/main/java/org/prebid/server/bidder/adhese/AdheseBidder.java
Outdated
Show resolved
Hide resolved
SerhiiNahornyi
suggested changes
Feb 18, 2021
src/main/java/org/prebid/server/bidder/adhese/AdheseBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/adhese/model/AdheseRequestBody.java
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/adhese/model/AdheseRequestBody.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/adhese/model/AdheseRequestBody.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/adhese/model/AdheseRequestBody.java
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/adhese/model/AdheseRequestBody.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/adhese/AdheseBidderTest.java
Outdated
Show resolved
Hide resolved
rpanchyk
suggested changes
Apr 27, 2021
src/test/java/org/prebid/server/bidder/adhese/AdheseBidderTest.java
Outdated
Show resolved
Hide resolved
| .withHeader("Accept", WireMock.equalTo("application/json")) | ||
| .withHeader("Content-Type", WireMock.equalTo("application/json;charset=UTF-8")) | ||
| .withRequestBody(WireMock.absent()) | ||
| .withRequestBody(WireMock.equalToJson("{\"slots\":[{\"slotname\":\"_adhese_prebid_demo_-leaderboard\"}],\"parameters\":{\"ag\":[\"55\"],\"ci\":[\"gent\",\"brussels\"],\"tl\":[\"all\"],\"xt\":[\"consentValue\"],\"xf\":[\"http://www.example.com\"],\"xz\":[\"ifaId\"]}}")) |
There was a problem hiding this comment.
@sander-adhese Agree with the above?
rpanchyk
approved these changes
Apr 28, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
* Use POST, preserve original user agent and user ip in the headers * Apply stash * Use obj serialization * Leave out unnecessary field * throw away unnecessary stuff * Comply with code style * Process feedback * Looks like this can't go * Process feedback * Process feedback * Replace literal JSON strings with AdheseRequestBody * fix over-sized line * Replace List.of with Arrays.asList * Replace the other Java 9 shorthands * Explicit typing
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
* Use POST, preserve original user agent and user ip in the headers * Apply stash * Use obj serialization * Leave out unnecessary field * throw away unnecessary stuff * Comply with code style * Process feedback * Looks like this can't go * Process feedback * Process feedback * Replace literal JSON strings with AdheseRequestBody * fix over-sized line * Replace List.of with Arrays.asList * Replace the other Java 9 shorthands * Explicit typing
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
* Use POST, preserve original user agent and user ip in the headers * Apply stash * Use obj serialization * Leave out unnecessary field * throw away unnecessary stuff * Comply with code style * Process feedback * Looks like this can't go * Process feedback * Process feedback * Replace literal JSON strings with AdheseRequestBody * fix over-sized line * Replace List.of with Arrays.asList * Replace the other Java 9 shorthands * Explicit typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send an actual body with data
Purge this data from the URL used