Update Eplanning Bidder with sizes priority by device type #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assertThat(result.getErrors()).isEmpty(); | ||
| assertThat(result.getValue()).hasSize(1) | ||
| .extracting(HttpRequest::getUri) | ||
| .containsOnly("https://eplanning.com/clientId/1/FILE/ROS?r=pbs&ncb=1&ur=FILE&e=testadun_itco_de%3A" |
There was a problem hiding this comment.
Can be used containsExactly() and then no .hasSize(1) needed
There was a problem hiding this comment.
I think it is much more easier for reader to identify that there can be only one request by hasSize(1) than counting how many values were passed to containsExactly. But probably one hasSize() use for test dedicated to checking that bidder produces only one request is enough, and in all other places containsExactly can be used.
SerhiiNahornyi
approved these changes
Feb 17, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
* Update Eplanning Bidder with sizes priority by device type * Minor cleaning * Replace containsOnly with containsExactly
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
* Update Eplanning Bidder with sizes priority by device type * Minor cleaning * Replace containsOnly with containsExactly
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
* Update Eplanning Bidder with sizes priority by device type * Minor cleaning * Replace containsOnly with containsExactly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.