Add new Pangle Bidder #1190
Merged
Add new Pangle Bidder #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpanchyk
suggested changes
Apr 26, 2021
| } | ||
|
|
||
| private static Integer resolveAdType(Imp imp, WrappedImpExtBidder extBidder) { | ||
|
|
| return -1; | ||
| } | ||
|
|
||
| private static boolean isEqualIntegers(Integer firstNum, Integer secondNum) { |
There was a problem hiding this comment.
Why we cant use plain Objects.equals() ?
| } | ||
| } | ||
|
|
||
| private static Integer resolveAdType(Imp imp, WrappedImpExtBidder extBidder) { |
There was a problem hiding this comment.
Can return type be of primitive type?
| return 5; | ||
| } | ||
|
|
||
| return -1; |
There was a problem hiding this comment.
Can we throw PreBidException right here?
|
|
||
| private static MultiMap makeHeaders(String token) { | ||
| return HttpUtil.headers() | ||
| .add("TOKEN", token); |
There was a problem hiding this comment.
From pangle.json
"required": [
"token"
]
Seems it can't be null
| } | ||
|
|
||
| private Integer getAdTypeFromBidExt(Bid bid) { | ||
| if (bid == null) { |
There was a problem hiding this comment.
Can we add .filter(Objects::nonNull) while looping through the bids?
There was a problem hiding this comment.
From Go implementation, they want to add errors about not present bids
rpanchyk
approved these changes
Apr 27, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from prebid/prebid-server#1697