Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert preconfigured bidder aliases to be added in bid request #1215

Merged
merged 4 commits into from
Apr 7, 2021

Conversation

rpanchyk
Copy link
Contributor

@rpanchyk rpanchyk commented Apr 7, 2021

As of PBS-Go has pre-configured aliases in default config we should do the same (Or it can be discussed with community).

For PBS-Java that was ported in #204

@rpanchyk rpanchyk requested a review from SerhiiNahornyi April 7, 2021 13:07
SerhiiNahornyi
SerhiiNahornyi previously approved these changes Apr 7, 2021
Copy link
Collaborator

@SerhiiNahornyi SerhiiNahornyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rpanchyk rpanchyk merged commit 55e0fb6 into master Apr 7, 2021
@rpanchyk rpanchyk deleted the revert-preconfigured-aliases branch April 7, 2021 13:38
rpanchyk added a commit that referenced this pull request Apr 7, 2021
rpanchyk added a commit that referenced this pull request Apr 7, 2021
nickluck9 pushed a commit that referenced this pull request Aug 9, 2021
nickluck9 pushed a commit that referenced this pull request Aug 10, 2021
nickluck9 pushed a commit that referenced this pull request Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants