Openx: use bidfloor if set - prebid.js adapter behavior #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
laurb9
commented
Apr 7, 2021
•
laurb9
commented
- Fixes bug that set bidfloor to null when customFloor not given (so almost always)
- Implements behavior in https://github.com/prebid/Prebid.js/blob/master/modules/openxBidAdapter.js#L495
- Ref Some adapters dropping bidfloors prebid-server#1787
- Same change as Openx: use bidfloor if set - prebid.js adapter behavior prebid-server#1795 for PBS-Go
SerhiiNahornyi
suggested changes
Apr 8, 2021
- Fixes bug that set bidfloor to 0 when customFloor not given (so almost always) - Implements behavior in https://github.com/prebid/Prebid.js/blob/master/modules/openxBidAdapter.js#L495
laurb9
changed the title
|
Added unit tests and simplified the code, passing bidfloor with fallback to customFloor. |
SerhiiNahornyi
approved these changes
Apr 9, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
- Fixes bug that set bidfloor to 0 when customFloor not given (so almost always) - Implements behavior in https://github.com/prebid/Prebid.js/blob/master/modules/openxBidAdapter.js#L495
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
- Fixes bug that set bidfloor to 0 when customFloor not given (so almost always) - Implements behavior in https://github.com/prebid/Prebid.js/blob/master/modules/openxBidAdapter.js#L495
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
- Fixes bug that set bidfloor to 0 when customFloor not given (so almost always) - Implements behavior in https://github.com/prebid/Prebid.js/blob/master/modules/openxBidAdapter.js#L495
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.