Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adtarget, Adtelligent, Mediafuse: Update sync type #1220

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Adtarget, Adtelligent, Mediafuse: Update sync type #1220

merged 1 commit into from
Apr 21, 2021

Conversation

RodionOrets
Copy link
Contributor

@RodionOrets RodionOrets commented Apr 12, 2021 •
edited
Loading

SerhiiNahornyi
SerhiiNahornyi suggested changes Apr 13, 2021
View reviewed changes
Copy link
Collaborator

@SerhiiNahornyi SerhiiNahornyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As u can see from Go PR, properties usersync.url and usersync.redirect-url are completely removed

@RodionOrets RodionOrets force-pushed the update-sync-type-adtarget-adtelligent-mediafuse branch from 46b97dc to 4c56ab9 Compare April 13, 2021 22:36
@RodionOrets RodionOrets force-pushed the update-sync-type-adtarget-adtelligent-mediafuse branch from 4c56ab9 to 445be2e Compare April 14, 2021 12:43
@rpanchyk rpanchyk merged commit 32407f0 into master Apr 21, 2021
@rpanchyk rpanchyk deleted the update-sync-type-adtarget-adtelligent-mediafuse branch April 21, 2021 06:52
nickluck9 pushed a commit that referenced this pull request Aug 9, 2021
@RodionOrets
Adtarget, Adtelligent, Mediafuse: Update sync type (#1220)
d51604d
nickluck9 pushed a commit that referenced this pull request Aug 10, 2021
@RodionOrets
Adtarget, Adtelligent, Mediafuse: Update sync type (#1220)
a07ecd6
nickluck9 pushed a commit that referenced this pull request Aug 10, 2021
@RodionOrets
Adtarget, Adtelligent, Mediafuse: Update sync type (#1220)
56e9405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SerhiiNahornyi SerhiiNahornyi SerhiiNahornyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RodionOrets @SerhiiNahornyi @rpanchyk