-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add App support for Smaato #1221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNahornyi
suggested changes
Apr 13, 2021
src/main/java/org/prebid/server/bidder/smaato/SmaatoBidder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/bidder/smaato/SmaatoBidder.java
Outdated
Show resolved
Hide resolved
RodionOrets
force-pushed
the
add-app-support-for-smaato
branch
from
April 14, 2021 00:57
bf686e7
to
cfdb5ad
Compare
SerhiiNahornyi
suggested changes
Apr 14, 2021
src/test/java/org/prebid/server/bidder/smaato/SmaatoBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/smaato/SmaatoBidderTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/smaato/SmaatoBidderTest.java
Outdated
Show resolved
Hide resolved
RodionOrets
force-pushed
the
add-app-support-for-smaato
branch
from
April 14, 2021 12:56
cfdb5ad
to
df21b3f
Compare
RodionOrets
force-pushed
the
add-app-support-for-smaato
branch
from
April 19, 2021 10:33
df21b3f
to
d5cf139
Compare
SerhiiNahornyi
suggested changes
Apr 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls remove new integration test files, as u can add App object in existing test files
src/test/java/org/prebid/server/bidder/smaato/SmaatoBidderTest.java
Outdated
Show resolved
Hide resolved
RodionOrets
force-pushed
the
add-app-support-for-smaato
branch
from
April 20, 2021 09:29
d5cf139
to
cd3b840
Compare
RodionOrets
force-pushed
the
add-app-support-for-smaato
branch
from
April 20, 2021 09:46
cd3b840
to
15ac977
Compare
SerhiiNahornyi
approved these changes
Apr 20, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go
repo PR: prebid/prebid-server#1767