DMX: Enforcing w and h in imp #1245
Conversation
RodionOrets
force-pushed
the
enforce-w-and-h-in-dmx-imp
branch
2 times, most recently
from
bc57a15 to
5f66aa2
Compare
RodionOrets
force-pushed
the
enforce-w-and-h-in-dmx-imp
branch
from
5f66aa2 to
661b1c1
Compare
| return app == null | ||
| ? null | ||
| : app.toBuilder() | ||
| .id(StringUtils.isNotBlank(app.getId()) ? app.getId() : device.getIfa()) |
There was a problem hiding this comment.
Can device here be null?
There was a problem hiding this comment.
If device is null, then validateRequest method would throw an PreBidException. I'll add unit test to cover this case
There was a problem hiding this comment.
As I see validateRequest will not throw ex with some userValues, and null device can be passed forward
There was a problem hiding this comment.
In real world, we expect that device being null is kinda impossible because it holds the info about physical device through which user is interacting with website/app. Anyway, I'll add device == null check to validateRequest
There was a problem hiding this comment.
As I know, we have stored requests and AMP, which as I know can not hold any user information
There was a problem hiding this comment.
Interesting. Seems we can't have null device because of Ortb2ImplicitParametersResolver.populateDevice()
RodionOrets
force-pushed
the
enforce-w-and-h-in-dmx-imp
branch
from
661b1c1 to
02dc60a
Compare
RodionOrets
force-pushed
the
enforce-w-and-h-in-dmx-imp
branch
from
02dc60a to
307e144
Compare
I see. Completely agree. I've tried to rearrange them and keep the abstraction level |
RodionOrets
force-pushed
the
enforce-w-and-h-in-dmx-imp
branch
from
307e144 to
8b2a46f
Compare
| return app == null | ||
| ? null | ||
| : app.toBuilder() | ||
| .id(StringUtils.isNotBlank(app.getId()) ? app.getId() : device.getIfa()) |
There was a problem hiding this comment.
Interesting. Seems we can't have null device because of Ortb2ImplicitParametersResolver.populateDevice()
RodionOrets
force-pushed
the
enforce-w-and-h-in-dmx-imp
branch
2 times, most recently
from
1b2c4f3 to
10f342d
Compare
RodionOrets
force-pushed
the
enforce-w-and-h-in-dmx-imp
branch
from
10f342d to
41f4dbc
Compare
prebid/prebid-server#1778