PBJ: Improve CookieSync and Setuid logging and metrics #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 28, 2021 13:17
# Conflicts: # src/main/java/org/prebid/server/metric/Metrics.java
rpanchyk
suggested changes
May 18, 2021
docs/metrics.md
Outdated
| @@ -115,6 +115,8 @@ Following metrics are collected and submitted if account is configured with `det | |||
| - `usersync.bad_requests` - number of requests received with bidder not specified | |||
| - `usersync.<bidder-name>.sets` - number of requests received resulted in `uid` cookie update for `<bidder-name>` | |||
| - `usersync.<bidder-name>.tcf.blocked` - number of requests received that didn't result in `uid` cookie update for `<bidder-name>` because of lack of user consent for this action according to TCF | |||
| - `usersync.<bidder-name>.tcf.invalid` - number of requests received that are lacking of a valid consent string for `<bidder-name>` | |||
There was a problem hiding this comment.
Pls do mention /setuid here.
docs/metrics.md
Outdated
| @@ -115,6 +115,8 @@ Following metrics are collected and submitted if account is configured with `det | |||
| - `usersync.bad_requests` - number of requests received with bidder not specified | |||
| - `usersync.<bidder-name>.sets` - number of requests received resulted in `uid` cookie update for `<bidder-name>` | |||
| - `usersync.<bidder-name>.tcf.blocked` - number of requests received that didn't result in `uid` cookie update for `<bidder-name>` because of lack of user consent for this action according to TCF | |||
| - `usersync.<bidder-name>.tcf.invalid` - number of requests received that are lacking of a valid consent string for `<bidder-name>` | |||
| - `usersync.all.tcf.invalid` - number of requests received that are lacking of a valid consent string for all requested bidders | |||
There was a problem hiding this comment.
Pls do mention /cooki_sync here.
| userSync().forBidder(bidder).tcf().incCounter(MetricName.invalid); | ||
| } | ||
|
|
||
| public void updateUserSyncTcfInvalidMetricForAllBidders() { |
There was a problem hiding this comment.
This method can overloaded from updateUserSyncTcfInvalidMetric but without args.
Also, it call updateUserSyncTcfInvalidMetric(ALL_REQUEST_BIDDERS) directly.
| @@ -245,7 +246,7 @@ public void shouldRespondWithBadRequestStatusIfGdprConsentIsInvalid() { | |||
| // given | |||
| given(routingContext.getBody()) | |||
| .willReturn(givenRequestBody(CookieSyncRequest.builder() | |||
| .bidders(emptyList()) | |||
| .bidders(Collections.singletonList(RUBICON)) | |||
There was a problem hiding this comment.
In tests we'd rather prefer to use static method imports to rid off Collections., etc.
rpanchyk
approved these changes
May 18, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.