Add bidderInfoResponse container as a first step to use BidInfo in workflow #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/org/prebid/server/auction/BidResponseCreator.java # src/main/java/org/prebid/server/auction/model/BidInfo.java
rpanchyk
suggested changes
Apr 29, 2021
| import java.util.List; | ||
|
|
||
| /** | ||
| * Seatid returned by a {@link Bidder}. |
| */ | ||
| @AllArgsConstructor(staticName = "of") | ||
| @Value | ||
| public class BidderInfoSeatBid { |
There was a problem hiding this comment.
Or BidderSeatBidInfo ? ;-)
| public class BidderInfoSeatBid { | ||
|
|
||
| /** | ||
| * List of bids which bidder wishes to make. |
There was a problem hiding this comment.
Probably we can skip java docs in this model since we've already described in original BidderSeatBid.
| /** | ||
| * List of bids which bidder wishes to make. | ||
| */ | ||
| List<BidInfo> bids; |
| */ | ||
| @AllArgsConstructor(staticName = "of") | ||
| @Value | ||
| public class BidderInfoResponse { |
| return imps.stream() | ||
| .filter(imp -> Objects.equals(impId, imp.getId())) | ||
| .findFirst() | ||
| // Should never occur. See ResponseBidValidator |
There was a problem hiding this comment.
Actually, we can if secureMarkupEnforcement == skip.
There was a problem hiding this comment.
Will be fixed in next PR.
rpanchyk
approved these changes
Apr 29, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
SerhiiNahornyi
pushed a commit
that referenced
this pull request
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1249