Openx: use bidfloor if set - prebid.js adapter behavior #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNahornyi
suggested changes
May 12, 2021
RodionOrets
force-pushed
the
align-openx-with-prebidjs-adapter-behavior
branch
from
f14d9c4 to
bb895ee
Compare
SerhiiNahornyi
suggested changes
May 12, 2021
Comment on lines
368
to
375
| .containsExactly(BidRequest.builder() | ||
| .imp(singletonList(Imp.builder() | ||
| .bidfloor(customFloor) | ||
| .video(Video.builder().build()) | ||
| .build())) | ||
| .ext(jacksonMapper.fillExtension( | ||
| ExtRequest.empty(), OpenxRequestExt.of(null, null, "hb_pbs_1.0.0"))) | ||
| .build()); |
There was a problem hiding this comment.
Just floor check is enough
There was a problem hiding this comment.
Actually just floor check is not enough because of this explicit .ext fulfilment: https://github.com/prebid/prebid-server-java/blob/master/src/main/java/org/prebid/server/bidder/openx/OpenxBidder.java#L176-L181
src/test/java/org/prebid/server/bidder/openx/OpenxBidderTest.java
Outdated
Show resolved
Hide resolved
RodionOrets
force-pushed
the
align-openx-with-prebidjs-adapter-behavior
branch
2 times, most recently
from
cea21dc to
2bc1dbe
Compare
RodionOrets
force-pushed
the
align-openx-with-prebidjs-adapter-behavior
branch
from
2bc1dbe to
53d80c1
Compare
SerhiiNahornyi
previously approved these changes
May 12, 2021
RodionOrets
force-pushed
the
align-openx-with-prebidjs-adapter-behavior
branch
from
53d80c1 to
d591807
Compare
SerhiiNahornyi
approved these changes
May 12, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prebid/prebid-server#1795