Update Vast logic #1271
Merged
Update Vast logic #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 18, 2021 03:00
# Conflicts: # src/test/resources/org/prebid/server/it/openrtb2/rubicon_appnexus/test-auction-rubicon-appnexus-response.json
schernysh
reviewed
May 25, 2021
| final String impressionUrl = "<![CDATA[" + vastUrlTracking + "]]>"; | ||
| final String openTag = "<Impression>"; | ||
| final String impressionTag = "<Impression><![CDATA[" + vastUrlTracking + "]]></Impression>"; | ||
| final String inlineCloseTag = IN_LINE_TAG.replace("<", "</"); |
There was a problem hiding this comment.
This is a constant actually, there is no need to create a new string for each invocation.
| } | ||
|
|
||
| private String appendTrackingUrlForWrapperType(String vastXml, String vastUrlTracking, Integer wrapperTagIndex) { | ||
| final String impressionTag = "<Impression><![CDATA[" + vastUrlTracking + "]]></Impression>"; |
There was a problem hiding this comment.
Impression tag construction looks similar across this and previous methods and is a good candidate for a separate method.
|
|
||
| return vastXml.replaceFirst(closeTag, closeTag + openTag + impressionUrl + closeTag); | ||
| return vastXml.replaceFirst(WRAPPER_TAG, WRAPPER_TAG + impressionTag); |
There was a problem hiding this comment.
It might be technically correct but still causes itching somehow. Can we insert impression tag in wrapper after the last present impression to be in line with how it is done in inline object?
added 3 commits
June 1, 2021 23:24
# Conflicts: # src/main/java/org/prebid/server/auction/BidResponseCreator.java # src/test/resources/org/prebid/server/it/openrtb2/rubicon_appnexus/test-auction-rubicon-appnexus-response.json
SerhiiNahornyi
force-pushed
the
vast/modify/update
branch
from
ff3c76a to
3be15d1
Compare
schernysh
suggested changes
Jun 3, 2021
| @@ -163,6 +163,7 @@ private static int validateTruncateAttrChars(int truncateAttrChars) { | |||
| AuctionContext auctionContext, | |||
| BidRequestCacheInfo cacheInfo, | |||
| Map<String, MultiBidConfig> bidderToMultiBids, | |||
| List<String> debugWarnings, | |||
There was a problem hiding this comment.
This parameter doesn't look necessary - debugWarnings could be obtained from auctionContext
schernysh
suggested changes
Jun 3, 2021
| return appendTrackingUrl(vastXml, vastUrlTracking, false); | ||
| } | ||
| metrics.updateAdapterRequestErrorMetric(bidder, MetricName.badserverresponse); | ||
| if (debugWarnings != null) { |
There was a problem hiding this comment.
From what I see debugWarnings shouldn't be null ever.
added 2 commits
June 3, 2021 18:08
schernysh
approved these changes
Jun 4, 2021
This was referenced Jun 9, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.