IX: Set bidVideo when category and duration is available #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RodionOrets
force-pushed
the
indexexchange-disable-by-default-and-set-bidVideo-if-applicable
branch
from
674187b to
49ae4bb
Compare
SerhiiNahornyi
suggested changes
May 19, 2021
| url: | ||
| redirect-url: | ||
| url: https://ssum.casalemedia.com/usermatchredir?gdpr={{gdpr}}&gdpr_consent={{gdpr_consent}}&us_privacy={{us_privacy}}&r= | ||
| redirect-url: /setuid?bidder=improvedigital&gdpr={{gdpr}}&gdpr_consent={{gdpr_consent}}&us_privacy={{us_privacy}}&uid={{uid}} |
There was a problem hiding this comment.
You've taken wrong link
There was a problem hiding this comment.
Also they have deleted endpoint value, pls set is as https://
There was a problem hiding this comment.
There was a problem hiding this comment.
bidder=improvedigital it's wrong link
| @@ -46,6 +51,8 @@ | |||
| // maximum number of bid requests | |||
| private static final int REQUEST_LIMIT = 20; | |||
|
|
|||
| private static final String PREBID = "prebid"; | |||
There was a problem hiding this comment.
You never use this constant
There was a problem hiding this comment.
Seems this constant is still never used
RodionOrets
force-pushed
the
indexexchange-disable-by-default-and-set-bidVideo-if-applicable
branch
from
49ae4bb to
819aa87
Compare
SerhiiNahornyi
suggested changes
May 20, 2021
| @@ -46,6 +51,8 @@ | |||
| // maximum number of bid requests | |||
| private static final int REQUEST_LIMIT = 20; | |||
|
|
|||
| private static final String PREBID = "prebid"; | |||
There was a problem hiding this comment.
Seems this constant is still never used
| private BidderBid toBidderBid(Bid bid, BidRequest bidRequest, BidResponse bidResponse) { | ||
| final BidType bidType = getBidType(bid.getImpid(), bidRequest.getImp()); | ||
|
|
||
| Bid.BidBuilder bidBuilder = bid.toBuilder(); |
There was a problem hiding this comment.
Creating builder is not a cheap operation. Can we update logic to create builder only in case if we really need it?
There was a problem hiding this comment.
Still can be final
RodionOrets
force-pushed
the
indexexchange-disable-by-default-and-set-bidVideo-if-applicable
branch
from
819aa87 to
1b14554
Compare
SerhiiNahornyi
suggested changes
May 21, 2021
| private BidderBid toBidderBid(Bid bid, BidRequest bidRequest, BidResponse bidResponse) { | ||
| final BidType bidType = getBidType(bid.getImpid(), bidRequest.getImp()); | ||
|
|
||
| Bid.BidBuilder bidBuilder = bid.toBuilder(); |
There was a problem hiding this comment.
Still can be final
RodionOrets
force-pushed
the
indexexchange-disable-by-default-and-set-bidVideo-if-applicable
branch
from
1b14554 to
89cacc9
Compare
RodionOrets
force-pushed
the
indexexchange-disable-by-default-and-set-bidVideo-if-applicable
branch
from
89cacc9 to
d5d292b
Compare
rpanchyk
previously approved these changes
May 24, 2021
rpanchyk
approved these changes
Jun 7, 2021
rpanchyk
deleted the
indexexchange-disable-by-default-and-set-bidVideo-if-applicable
branch
muuki88
reviewed
Jun 25, 2021
| url: | ||
| redirect-url: | ||
| url: https://ssum.casalemedia.com/usermatchredir?s=189517&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&cb= | ||
| redirect-url: /setuid?bidder=ix&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&uid= |
There was a problem hiding this comment.
This link contains the GO server macros, not the java ones @RodionOrets
There was a problem hiding this comment.
I guess it should be
/setuid?bidder=ix&gdpr={{gdpr}}&gdpr_consent={{gdpr_consent}}&us_privacy={{us_privacy}}&uid=
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prebid/prebid-server#1799
prebid/prebid-server#1794
prebid/prebid-server#1837