Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Bidder: Adf #1288

Merged
merged 6 commits into from
Jun 2, 2021
Merged

New Bidder: Adf #1288

merged 6 commits into from
Jun 2, 2021

Conversation

nickluck9
Copy link

No description provided.

@nickluck9 nickluck9 changed the title new adf bidder was added New Bidder: Adf May 28, 2021
Adf bidder
c4a7845 
fix tests
@nickluck9 nickluck9 requested a review from SerhiiNahornyi May 28, 2021 13:13
@muuki88
Copy link
Contributor

muuki88 commented May 31, 2021

@nickluck8 there's already an AdForm bidder available.

Can you highlight the difference and which one should be chosen? From the implementation I can see that
the adf one uses the standard OpenrtbBidder, which is great. So in general it would be nice to know

  • can both adapters be used?
  • is there a difference in formats, demand, future support?

@rpanchyk
Copy link
Contributor

@muuki88 seems ADF - https://adx.adform.net/adx/openrtb is OpenRTB exchange instead of AdForm - https://adx.adform.net/adx where custom GET request used.
So, it depends on publisher which one to use.

SerhiiNahornyi
SerhiiNahornyi suggested changes May 31, 2021
View reviewed changes
Copy link
Collaborator

@SerhiiNahornyi SerhiiNahornyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this PR should be updated, with this changes prebid/prebid-server#1841

@SerhiiNahornyi SerhiiNahornyi self-requested a review June 1, 2021 13:15
@rpanchyk rpanchyk merged commit 967bf3b into master Jun 2, 2021
@rpanchyk rpanchyk deleted the adf-bidder branch June 2, 2021 08:11
nickluck9 pushed a commit that referenced this pull request Aug 9, 2021
New Bidder: Adf (#1288)
9157bf5
nickluck9 pushed a commit that referenced this pull request Aug 10, 2021
New Bidder: Adf (#1288)
383a67b
nickluck9 pushed a commit that referenced this pull request Aug 10, 2021
New Bidder: Adf (#1288)
fb1da91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SerhiiNahornyi SerhiiNahornyi SerhiiNahornyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nickluck9 @muuki88 @rpanchyk @SerhiiNahornyi