Add processing of imp.ext.data to mediagrid #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNahornyi
suggested changes
Jun 3, 2021
|
|
||
| @AllArgsConstructor(staticName = "of") | ||
| @Value | ||
| public class ExtImp { |
There was a problem hiding this comment.
In custom models we prefer to use names like {bidderName}modelName
| @@ -21,6 +24,28 @@ protected Imp modifyImp(Imp imp, ExtImpGrid impExt) { | |||
| if (impExt.getUid() == null || impExt.getUid() == 0) { | |||
| throw new PreBidException("uid is empty"); | |||
| } | |||
| ExtImp extImp = mapper.mapper().convertValue( | |||
| && extImp.getExtImpData().getAdServer() != null | ||
| && StringUtils.isNotEmpty(extImp.getExtImpData().getAdServer().getAdSlot())) { | ||
|
|
||
| ExtImp modifiedExtImp = ExtImp.of(extImp.getPrebid(), |
There was a problem hiding this comment.
Can be final, and also you create model with of constructor, just to change one value, lets use builder
Comment on lines
32
to
35
| if (extImp != null | ||
| && extImp.getExtImpData() != null | ||
| && extImp.getExtImpData().getAdServer() != null | ||
| && StringUtils.isNotEmpty(extImp.getExtImpData().getAdServer().getAdSlot())) { |
There was a problem hiding this comment.
Lets extract adSlot, and then use if statement
| extImp.getExtImpData(), | ||
| extImp.getExtImpData().getAdServer().getAdSlot()); | ||
|
|
||
| ObjectNode modifiedExt = mapper.mapper().valueToTree( |
There was a problem hiding this comment.
we can move it directly to imp building
imp.toBuilder().ext(mapper.mapper().valueToTree(modifiedExtImp)).build()
SerhiiNahornyi
suggested changes
Jun 3, 2021
| GridExtImp.class | ||
| ); | ||
|
|
||
| String adSlot = getAdSlot(gridExtImp); |
There was a problem hiding this comment.
Can be final, but also by saying extracting I mean that we can do something like
final GridExtImp gridExtImp = mapper.mapper().convertValue(imp.getExt(), GridExtImp.class);
final GridExtImpData extImpData = gridExtImp != null ? gridExtImp.getGridExtImpData() : null;
final GridExtImpDataAdServer adServer = extImpData != null ? extImpData.getAdServer() : null;
final String adSlot = adServer != null ? adServer.getAdSlot() : null;
if (StringUtils.isNotEmpty(adSlot)) {
Comment on lines
26
to
29
| final GridExtImp gridExtImp = mapper.mapper().convertValue( | ||
| imp.getExt(), | ||
| GridExtImp.class | ||
| ); |
Comment on lines
244
to
246
| Imp imp = Imp.builder() | ||
| .ext(mapper.valueToTree(gridExtImp)) | ||
| .build(); |
There was a problem hiding this comment.
Can be one line and also final
SerhiiNahornyi
previously approved these changes
Jun 3, 2021
|
This pull request introduces 1 alert when merging 5b5d95d into 5e2b94f - view on LGTM.com new alerts:
|
rpanchyk
changed the title
rpanchyk
suggested changes
Jun 3, 2021
src/main/java/org/prebid/server/bidder/grid/model/GridExtImp.java
Outdated
Show resolved
Hide resolved
add try/catch clause
rpanchyk
approved these changes
Jun 4, 2021
|
This pull request introduces 1 alert when merging 653da6e into 2874e8c - view on LGTM.com new alerts:
|
SerhiiNahornyi
approved these changes
Jun 4, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prebid/prebid-server#1807