Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AnalyticsReporterDelegator to tolerate with missing BidRequest #1302

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Update AnalyticsReporterDelegator to tolerate with missing BidRequest #1302

merged 1 commit into from
Jun 8, 2021

Conversation

SerhiiNahornyi
Copy link
Collaborator

@SerhiiNahornyi SerhiiNahornyi commented Jun 8, 2021 •
edited by rpanchyk
Loading

Fixes NPE:

2021-06-08 02:59:02.352 ERROR 13870 --- [vert.x-eventloop-thread-2] io.vertx.core.impl.ContextImpl : Unhandled exception

java.lang.NullPointerException: null
at org.prebid.server.analytics.AnalyticsReporterDelegator.logUnknownAdapters(AnalyticsReporterDelegator.java:114)
at org.prebid.server.analytics.AnalyticsReporterDelegator.checkUnknownAdaptersForAuctionEvent(AnalyticsReporterDelegator.java:109)
at org.prebid.server.analytics.AnalyticsReporterDelegator.delegateEvent(AnalyticsReporterDelegator.java:87)
at org.prebid.server.analytics.AnalyticsReporterDelegator.lambda$processEvent$1(AnalyticsReporterDelegator.java:78)
at io.vertx.core.impl.FutureImpl.setHandler(FutureImpl.java:80)

@lgtm-com
Copy link

lgtm-com bot commented Jun 8, 2021

This pull request introduces 2 alerts when merging efee093 into 81f950d - view on LGTM.com

new alerts:

  • 2 for Dereferenced variable may be null

@rpanchyk rpanchyk merged commit 7f1966f into master Jun 8, 2021
@rpanchyk rpanchyk deleted the tolerate/missing/request branch June 8, 2021 13:02
nickluck9 pushed a commit that referenced this pull request Aug 9, 2021
@SerhiiNahornyi
Update AnalyticsReporterDelegator to tolerate with missing BidRequest (…
6e4dd80 
…#1302)
nickluck9 pushed a commit that referenced this pull request Aug 10, 2021
@SerhiiNahornyi
Update AnalyticsReporterDelegator to tolerate with missing BidRequest (…
eaf4234 
…#1302)
nickluck9 pushed a commit that referenced this pull request Aug 10, 2021
@SerhiiNahornyi
Update AnalyticsReporterDelegator to tolerate with missing BidRequest (…
b8ecc9d 
…#1302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpanchyk rpanchyk rpanchyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SerhiiNahornyi @rpanchyk