Interactiveoffers bidder #1306
Merged
Interactiveoffers bidder #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 2, 2021 12:53
SerhiiNahornyi
suggested changes
Jun 10, 2021
Comment on lines
48
to
62
| final List<Imp> modifiedImps = new ArrayList<>(); | ||
|
|
||
| for (Imp imp : request.getImp()) { | ||
| try { | ||
| final ExtImpInteractiveoffers impExt = parseImpExt(imp); | ||
|
|
||
| if (impExt.getPubId() == null) { | ||
| throw new PreBidException("The pubid must be present"); | ||
| } | ||
|
|
||
| modifiedImps.add(imp.toBuilder().ext(impExtToObjectNode(impExt)).build()); | ||
| } catch (PreBidException e) { | ||
| return Result.withError(BidderError.badInput(e.getMessage())); | ||
| } | ||
| } |
There was a problem hiding this comment.
We don't need this, they don't do it in go, and also server will not process invalid ext request because of json validation schema
Comment on lines
70
to
71
| .payload(outgoingRequest) | ||
| .body(mapper.encode(outgoingRequest)) |
There was a problem hiding this comment.
.payload(request)
.body(mapper.encode(request))Since we don't need any updated request
Comment on lines
86
to
94
| private ObjectNode impExtToObjectNode(ExtImpInteractiveoffers interactiveOffersBidder) { | ||
| final ObjectNode impExt; | ||
| try { | ||
| impExt = mapper.mapper().valueToTree(ExtPrebid.of(null, interactiveOffersBidder)); | ||
| } catch (IllegalArgumentException e) { | ||
| throw new PreBidException(String.format("Failed to create imp.ext with error: %s", e.getMessage())); | ||
| } | ||
| return impExt; | ||
| } |
Comment on lines
113
to
119
| private ExtImpInteractiveoffers parseImpExt(Imp imp) { | ||
| try { | ||
| return mapper.mapper().convertValue(imp.getExt(), INTERACTIVEOFFERS_EXT_TYPE_REFERENCE).getBidder(); | ||
| } catch (IllegalArgumentException e) { | ||
| throw new PreBidException(e.getMessage()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Also can be removed
Comment on lines
34
to
36
| private static final TypeReference<ExtPrebid<?, ExtImpInteractiveoffers>> INTERACTIVEOFFERS_EXT_TYPE_REFERENCE = | ||
| new TypeReference<ExtPrebid<?, ExtImpInteractiveoffers>>() { | ||
| }; |
src/main/java/org/prebid/server/bidder/interactiveoffers/InteractiveOffersBidder.java
Show resolved
Hide resolved
|
|
||
| @Test | ||
| public void creationShouldFailOnInvalidEndpointUrl() { | ||
| assertThatIllegalArgumentException().isThrownBy(() -> new OnetagBidder("invalid_url", jacksonMapper)); |
There was a problem hiding this comment.
new InteractiveOffersBidder
| .header("User-Agent", "userAgent") | ||
| .header("Origin", "http://www.example.com") | ||
| // this uids cookie value stands for {"uids":{"interactiveoffers":"interactiveoffers-UID"}} | ||
| .cookie("uids", "eyJ1aWRzIjp7ImFkbWFuIjoiQUQtVUlEIn19") |
There was a problem hiding this comment.
This one stands for {"uids":{"adman":"AD-UID"}}
Use this resource https://www.base64encode.org/ to create cookie that stands for {"uids":{"interactiveoffers":"IO-UID"}}
| public class ExtImpInteractiveoffers { | ||
|
|
||
| @JsonProperty("pubid") | ||
| Integer pubId; |
There was a problem hiding this comment.
Let's name it as pubid, and then we don't need @JsonProperty("pubid")
SerhiiNahornyi
previously approved these changes
Jun 11, 2021
nickluck9
pushed a commit
that referenced
this pull request
Jun 14, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.